Open vikramsubramanian opened 4 months ago
Summary: The documentation for the LIST data type DDL specifications needs to be clarified and improved.
To address the issue described, follow these steps:
LIST
types in DDL. Replace "same numerical type" with "same type" and provide clear examples for declaring LIST
types.VAR-LIST
and FIXED-LIST
as per the hypothesized documentation provided.FixedListTypeInfo
and VarListTypeInfo
in types.h
and their usage in value_vector.cpp
and data_type_test.cpp
are consistent with the updated documentation.data_type_test.cpp
and other relevant test files to cover the corrected documentation and any code changes made to ensure that VAR-LIST
and FIXED-LIST
behave as expected.LIST
types as per the updated documentation.src/include/common/types/types.h
This file contains the definitions and comments related to the LIST data types, which are directly relevant to the documentation issue.
Thanks for the great work on this project! I wanted to open a suggestion for [documentation surrounding the LIST data type]( which I thought might help clarify usage.
Currently the beginning of this page reads:
This could be improved with an additional statement concerning the use of other datatypes (any data type?) before the brackets in DDL. Additionally, it looked like there was a typo concerning the FIXED-LIST content ("same numerical type", not certain but it seems like this should be "same type").
It might be that the following content is inferred from other, more comprehensive documentation about the DDL grammar. Please don't hesitate to correct or link to a better resource instead of the below. Thank you! )