Wrong error message when setting object in an RDF Literal table (hashtag2792)

[vikramsubramanian]

I issued the following query:

kuzu> MATCH (a)-[p:TurtleTest_lt]->(o) 
WHERE p.iri = " 
SET o.val=cast(true, "BOOL") 
RETURN p.iri, o.val;  
Error: Binder exception: Cannot set property of o because it refers to table TurtleTest_r under rdf graph TurtleTest.

o must be in TurtleTest_l not TurtleTest_r.

So is it the case now that we cannot modify anything in RDFGraphs? First, I think we can allow them to set literals. I think that's fine. But if this is much easier, so we force them to delete and insert triples, then we should just give a better error message. Something like: Error: Binder exception: Cannot set properties of RDFGraph tables. You are trying to set o.val but o is part of table TurtleTest_l under RDFGraph TurtleTest.

Also Let's use the term RDFGraph instead of "rdf graph", which is what you have used in the error message.

)

[mayil-ai[bot]]

Summary: Error message incorrectly refers to the table in RDFGraph when setting object in an RDF Literal table.

Possible Solution

Based on the provided information, the issue seems to be related to an incorrect table reference in an RDFGraph operation within a query. The error message indicates that the property o.val cannot be set because it refers to the incorrect table TurtleTest_r instead of the correct table TurtleTest_l. To resolve this issue:

• Locate the part of the code responsible for parsing and executing the SET clause within RDFGraph operations, particularly where it handles property setting for literals.
• Ensure that the correct table reference (TurtleTest_l) is used when setting the property o.val.
• Update the error message generation logic to use consistent terminology ("RDFGraph") and to provide accurate table references in error messages.
• If the codebase contains a function similar to set_rdf_graph_property as hypothesized, review and correct the logic within this function to prevent incorrect table references.
• If the error message is generated based on pattern matching or predefined templates, update the relevant patterns or templates to reflect the correct table reference and terminology.
• Add or update unit tests to cover the scenario where a property of an RDFGraph is being set to ensure that the correct table reference is used and that the operation behaves as expected.

Please note that the provided code snippets do not directly contain the relevant code to fix the issue, so you will need to search the codebase for the appropriate files and functions that handle the SET clause and RDFGraph property setting.

Code snippets to check

• src/binder/bind/bind_graph_pattern.cpp

  This snippet is relevant because it contains logic related to binding RDF graph patterns, which is directly related to the issue of setting properties on RDFGraph tables.

• src/binder/bind/copy/bind_copy_rdf_graph.cpp

  This snippet is relevant as it deals with the binding process for copying RDF graphs, which may need to be reviewed to ensure proper error messages are generated when setting properties on RDFGraph tables.

• src/binder/bind/ddl/bind_create_rdf_graph.cpp

  This snippet is relevant because it includes code for binding the creation of RDF graphs, which might be involved in the process of setting properties and could be related to the error message issue.

• third_party/antlr4_cypher/cypher_parser.cpp

  This snippet is relevant as it contains the Cypher parser rules, which might need to be adjusted to provide better error messages when setting properties on RDFGraph tables.