CLI backward search issues (hashtag2761)

[vikramsubramanian]

On my regular terminal (on Mac), if I have the following behavior, which does not exist in Kuzu shell:

• [x] If I hit cntrl + r, then I don't type anything, and then type cntrl +r again, it shows the last command. Each additional cntr + r gets you to the one previous command etc. That is when you hit cntrl + r without typing anything, it is equivalent to pressing the up arrow key multiple times.
• [x] If I hit cntrl + r and type something, say "node", then it takes me to the last command that has the word "node" in it. Let's call this hit1. Then I cannot press up or down arrows to navigate the history before and after hit 1, e.g., to see the command before hit1 or after hit1.
• [x] Syntax highlighting: Instead of highlighting rdf and graph, rdfgraph should be higlighted. )

[mayil-ai[bot]]

Summary: Issues with CLI backward search behavior and syntax highlighting.

Possible Solution

Based on the provided information and code snippets, here is the solution to the issue:

• Issue with cntrl + r behavior:

  • Modify the keybinding for CTRL_R (which is not shown in the provided snippets but should be similar to other CTRL_ keybindings) to call a function that retrieves the last command from the history and displays it without requiring additional input.
  • Implement or modify the backward_search or history_navigation function to handle subsequent presses of CTRL_R to navigate to previous commands.

• Issue with typing "node" after cntrl + r:

  • Enhance the incremental_search function to filter the command history based on the input term after CTRL_R is pressed.
  • Ensure that the linenoiseEditHistoryNext function (or similar) allows navigation through the filtered results with CTRL_P and CTRL_N for previous and next commands, respectively.

• Issue with syntax highlighting for "rdfgraph":

  • Update the syntax_highlighting rules or the highlightCallback function to recognize "rdfgraph" as a single term.
  • This might involve adjusting the regular expression patterns used for syntax highlighting to match "rdfgraph" as a whole word rather than "rdf" and "graph" separately.

The relevant code snippets for these modifications are likely to be found in the linenoise.cpp file, where keybindings and editing functionalities are implemented. The embedded_shell.cpp file may contain the logic for syntax highlighting and should be reviewed for updates to the highlighting rules.

Code snippets to check

• tools/shell/linenoise.cpp

  This file contains the key bindings and behavior for the shell, which is relevant to the issue of backward search and key press behavior.

• tools/shell/embedded_shell.cpp

  This file contains the shell prompt and syntax highlighting logic, which is relevant to the issue of syntax highlighting.