CopyTo and CopyFrom do not align with interval datatype (hashtag2882)

[vikramsubramanian]

Copy To will write the interval datatype as the format 3 years 2 days 13:02:00, but Copy From can not recognize such a format. It will trigger an error Conversion exception: Unrecognized interval specifier string: :02:00." thrown in the test body.

Reproduce:

1. load node Table vPerson from the tinysnb dataset
2. using COPY TO statement to write into a csv file "test.csv"
3. using Copy Fromstament to load "test.csv" )

[mayil-ai[bot]]

Summary: Issue with CopyTo and CopyFrom not aligning with interval datatype format.

Possible Solution

Based on the provided information and code snippets, the issue seems to be related to the handling of the interval datatype during the CopyFrom operation. The error message indicates that the CopyFrom function cannot recognize the interval specifier string :02:00 when loading data from a CSV file.

To resolve the issue, follow these steps:

• Locate the code responsible for parsing the interval datatype in the CSV import functionality (CopyFrom operation). This code is likely to be in the src/binder/bind/bind_copy.cpp file or in a related file that handles CSV parsing and interval deserialization.
• Modify the interval parsing logic to correctly handle the format 3 years 2 days 13:02:00. Ensure that it can parse the hours, minutes, and seconds components of the interval string correctly.
• Update the interval parsing logic to recognize and correctly interpret the :02:00 part of the string as a valid time interval (2 hours and 0 minutes).
• Add unit tests to cover the case of interval strings with the problematic format to ensure that the parsing logic works as expected after the fix.
• Re-run the existing tests to ensure that the change does not break any other functionality.

The relevant code snippet for interval parsing is in the test/common/interval_test.cpp file, which contains tests for the Interval::fromCString function. This function is likely used in the CSV import process to convert interval strings from the CSV file into the internal interval_t representation. The fix should ensure that the Interval::fromCString function or its equivalent in the actual import code can handle the full interval format, including hours and minutes.

Code snippets to check

• test/common/interval_test.cpp

  This file contains tests for interval parsing which is relevant to the issue of Copy From not recognizing interval formats.

• src/binder/bind/bind_copy.cpp

  This file contains the binding logic for the Copy From statement, which is likely where the issue with interval datatype recognition needs to be addressed.

• src/processor/operator/persistent/copy_to_csv.cpp

  This file is related to the Copy To functionality and may contain the logic for writing interval datatypes to CSV, which is part of the issue.

• test/copy/e2e_copy_transaction_test.cpp

  This file contains end-to-end tests for copy transactions, which may need to be updated to include tests for the interval datatype issue.