Mayil-AI-Sandbox / vlc-ios

Clone of vlc ios for debugging
Other
1 stars 0 forks source link

Remaining time: Invalid display when the playback starts #2

Open vikramsubramanian opened 3 months ago

vikramsubramanian commented 3 months ago

The remaining time displayed above the progress bar does not display the correct value when the playback starts. It seems that the issue happens during the buffering state:

mayil-ai[bot] commented 3 months ago

To address the issue with the incorrect remaining time displayed above the progress bar in VLC media player for iOS and tvOS, follow these steps:

  1. Verify that the mediaDuration property in VLCPlaybackService is being set and updated correctly when the media is loaded and during state transitions, particularly from buffering to playing.

  2. Update the updateTimeLabelsForScrubbingFraction: method in VLCFullscreenMovieTVViewController.m to handle scenarios where mediaDuration might be inaccurate. This could involve checking the playback state and postponing the update of the remaining time until a valid duration is obtained.

  3. If the UI is being updated with outdated data, implement a system to refresh the UI with the correct remaining time once buffering is complete and playback has commenced.

  4. After making these changes, thoroughly test to confirm that the remaining time is accurately displayed when playback starts and that the issue is resolved across different playback situations.

Here are some code snippets that may help you get started:

💡 To rerun Mayil, comment mayil-ai rerun. Mayil will incorporate any new context added to the ticket. Include details in your rerun comment to guide Mayil!