Mayitzin / ahrs

Attitude and Heading Reference Systems in Python
https://ahrs.readthedocs.io/
MIT License
561 stars 89 forks source link

adaptive gain seems not correct in aqua algorithms #125

Open whoispo opened 1 week ago

whoispo commented 1 week ago

image

if alpha equals 0 then, alpha will be 0 forever. Because in the code, alpha updates: image

Even if f equals 1, then new alpha will be 0.

I have read the reference article, the gain is not stored and used again.
image

Mayitzin commented 6 days ago

You are right. The gain wasn't being properly updated.

The commit de6e3632055a57c45b1d66b21113174e66dad37e has modified this part and its calls within the algorithm. The changes are:

If you have further observations, let me know.