Mayuresh-22 / Minglr

Social Network Site developed using HTML, CSS, JS and PHP as a Backend Language. This site supports the functionality of login/registration and sharing the posts/photos through their accounts, also it has the functionality of private messaging with the users.
https://links.mayuresh.me/minglr
MIT License
36 stars 43 forks source link

Added New Footer Style [fixes #33] #73

Closed Ab369 closed 9 months ago

Ab369 commented 9 months ago
Mayuresh-22 commented 9 months ago

An issue with the PR

Home page:

image

Account and other pages

image

Ab369 commented 9 months ago

I will work on this

Ab369 commented 9 months ago

I have made the changes. Please review it

Mayuresh-22 commented 9 months ago

Current changes seem good I would like to suggest a few things:

  1. Reduce spaces between social icons.
  2. Add space between footer and page content to prevent content from getting hidden in the top navbar. (Highlighted in the image below) Capture (Content is shrinking in between the navbar top limit and the footer.
  3. Make the design responsive current changes are not responsive on mobile devices and other devices.
Ab369 commented 9 months ago

Sure, I will work on this

Ab369 commented 9 months ago

hey, I have updated the CSS with responsiveness. Please check it.

Mayuresh-22 commented 9 months ago

There's still no enough space at the top of the page. image

Ab369 commented 9 months ago

Hey @Mayuresh-22 , I am unable to figure out further and unable to work on this issue due to some other project. Please unassign this issue from me. Thanks for your consideration.