Mayuresh-22 / Minglr

Social Network Site developed using HTML, CSS, JS and PHP as a Backend Language. This site supports the functionality of login/registration and sharing the posts/photos through their accounts, also it has the functionality of private messaging with the users.
https://links.mayuresh.me/minglr
MIT License
36 stars 43 forks source link

I would like to add a dark mode into the minglr. #84

Closed bhatiaarpit closed 8 months ago

bhatiaarpit commented 9 months ago

I would like to add a dark mode into the UI of the Minglr and make changes into the UI which will enhance the look of minglr. Before Screenshot 2024-01-12 234133 After (its just a preview )

https://github.com/Mayuresh-22/Minglr/assets/118626392/57b3df49-f1b0-4243-8524-9d23b2d12439

Kindly assign this task to me under SWOC.

github-actions[bot] commented 9 months ago

Thank you for creating the first issue in Minglr!🎉

Mayuresh-22 commented 9 months ago

Hey buddy @bhatiaarpit, great job! I loved it. I suggest you experiment with different colour combinations and create a PR. I'll assign this issue to you ASAP.

bhatiaarpit commented 9 months ago

Thanks brother, on it!

Mayuresh-22 commented 9 months ago

Are you still working on it?

bhatiaarpit commented 9 months ago

Will complete in some days.. actually I got busy in my end sem exams.

On Fri, 26 Jan, 2024, 6:51 pm Mayuresh Choudhary, @.***> wrote:

Are you still working on it?

— Reply to this email directly, view it on GitHub https://github.com/Mayuresh-22/Minglr/issues/84#issuecomment-1912059428, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4JBQWAQXKMRZXLCXHURJIDYQOUVNAVCNFSM6AAAAABBYRAGAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGA2TSNBSHA . You are receiving this because you were assigned.Message ID: @.***>

Mayuresh-22 commented 8 months ago

@bhatiaarpit any updates?

bhatiaarpit commented 8 months ago

Screenshot 2024-02-10 004705 @Mayuresh-22 I added the dark mode on every page, but I still need to work on the design of minglr. Can I design a new logo for minglr?

Mayuresh-22 commented 8 months ago

It looks great and I appreciate your work, but can we do something with the navbar? As it should also be a part of the Night mode feature. Making a new logo for Minglr? Great idea I'll create a new issue for it then...

bhatiaarpit commented 8 months ago

Yes, definitely working on the other parts of minglr.

bhatiaarpit commented 8 months ago

@Mayuresh-22 Please Checkout the changes in minglr, In some pages there are some issues like CSS isn't loading on account page and on login page(Don't know why they're not loading), And others things are working fine. I also designed a logo for minglr cause I need to use the logo for the dark mode.

https://drive.google.com/file/d/127DdWZkce8N-GLdCcKARiZX1vW0TDSYi/view?usp=drivesdk

Mayuresh-22 commented 8 months ago

You have done a fabulous work. Even the "Minglr" logo is great; those extra additions make it more attractive. I watched the demo video and almost everything looks perfect, but the CSS not loading especially on /account.php will be the result of some file issues (We will look into it). Make sure the changes are responsive and work on the mobile devices as well. Else, everything seems good.

bhatiaarpit commented 8 months ago

@Mayuresh-22 There's an issue with CSS not loading on the account.php page, while other functionalities are working fine. Minglr is fully responsive on mobile devices. Checkout the other changes... https://drive.google.com/file/d/1j9nOfATKwpZdemwNvKS4qwrYMEfjvb5X/view?usp=sharing

Mayuresh-22 commented 8 months ago

Hey, good work, I watched the new video (showing mobile devices) and there I saw that the page layout (primarily of the account page) changes once we change the mode from light to dark. Please have a look into it.

On Sun, Feb 11, 2024 at 2:30 PM Arpit Bhatia @.***> wrote:

@Mayuresh-22 https://github.com/Mayuresh-22 There's an issue with CSS not loading on the account.php page, while other functionalities are working fine. Minglr is fully responsive on mobile devices. Checkout the other changes...

https://drive.google.com/file/d/1j9nOfATKwpZdemwNvKS4qwrYMEfjvb5X/view?usp=sharing

— Reply to this email directly, view it on GitHub https://github.com/Mayuresh-22/Minglr/issues/84#issuecomment-1937481263, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2RQZPQU3WZ6CO5YQPL7J4DYTCCC7AVCNFSM6AAAAABBYRAGAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXGQ4DCMRWGM . You are receiving this because you were mentioned.Message ID: @.***>

bhatiaarpit commented 8 months ago

@Mayuresh-22 There is an issue because the CSS for account.php isn't loading correctly.

bhatiaarpit commented 8 months ago

@Mayuresh-22 I've addressed all the issues. Take a look at Minglr now.

https://drive.google.com/file/d/1pXc4m5QQ8gp1MM3aW1hdq2Xz_uxG7-EG/view?usp=sharing

Mayuresh-22 commented 8 months ago

Hey buddy, I watched the demo video and I must say everything looks perfect that's great you've made such a great contribution. I think you can raise a PR under SWOC24

bhatiaarpit commented 8 months ago

@Mayuresh-22 I've initiated a pull request for your review. Kindly check it.

Mayuresh-22 commented 8 months ago

Successfully solved by #119

bhatiaarpit commented 8 months ago

@Mayuresh-22 Thankyou❤️