search

Mayuresh-22 / Minglr

Social Network Site developed using HTML, CSS, JS and PHP as a Backend Language. This site supports the functionality of login/registration and sharing the posts/photos through their accounts, also it has the functionality of private messaging with the users.
https://links.mayuresh.me/minglr
MIT License
37 stars 39 forks source link

Added Confirmation Logout Pop Up #96

Closed Amine2000s closed 7 months ago

Amine2000s commented 7 months ago

solved #61 Confiramtion_logout_on_message confirmation_logout_on_about_us confirmation_logout_on_feed confirmation_logout_on_account

Mayuresh-22 commented 7 months ago

CodeFactor found multiple issues last seen at cc363b7543a61c52b3c42dc8c559cdbb4bd8e28d:

Unexpected duplicate "display" (declaration-block-no-duplicate-properties)

Unexpected duplicate "border" (declaration-block-no-duplicate-properties)

Unexpected duplicate "padding" (declaration-block-no-duplicate-properties)

Unexpected duplicate "background-color" (declaration-block-no-duplicate-properties)

Amine2000s commented 7 months ago

@Mayuresh-22 everything is fixed And ready to merge

Mayuresh-22 commented 7 months ago

Hey @ Amine2000s, you have done a great job. But I saw you removed the password requirement JS code too. That's one of the important parts as the user gets the hint about the valid password they can use on Minglr. So please add it back so that it will again be a part of Minglr codebase.

Amine2000s commented 7 months ago

ohh! soory i forgot to get it back i will get it back

Amine2000s commented 7 months ago

the js confiramtion logic is back @Mayuresh-22

Amine2000s commented 7 months ago

the password hints is also returned @Mayuresh-22

Mayuresh-22 commented 7 months ago

I see there isn't a password hint thing except everything is perfect image

Amine2000s commented 7 months ago

Password_hint

i meant this area of code , which i thought that is was kind of like a password "hint" to help user create a password with the specified rules

Mayuresh-22 commented 7 months ago

Password_hint

i meant this area of code , which i thought that is was kind of like a password "hint" to help user create a password with the specified rules Yes, you are correct. However, JS code triggers the above code block to appear. I'll suggest you to create new branch from Minglr's repo and then migrate your confirmation popup changes to it.

Amine2000s commented 7 months ago

@Mayuresh-22 i don't understand , you mean to fork a new repo , or do you mean create a new branch from my own actual fork? Otherwise, otherwise i can't create a new branch from the official Minglr repo

Amine2000s commented 7 months ago

@Mayuresh-22 hello ?

Mayuresh-22 commented 7 months ago

New PR with same title at #103