search

Mayvenn / limo

A wrapper around selenium webdriver
Eclipse Public License 1.0
25 stars 4 forks source link

bump selenium versions and add firefox support #4

Closed hlolli closed 6 years ago

hlolli commented 7 years ago

Firefox webdriver via geckodriver and Firefox 55+ works wonderfully on my computer. Bumping the selenium drivers caused clashes with jetty, so I excluded them and added seperate ring-jetty dependency to minimize dependency conflicts.

hlolli commented 7 years ago

Added another commit to this PR.

https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded

This js function doesn't exist in Firefox, so I changed it to scrollIntoView when the webdriver is set to firefox.

jeffh commented 7 years ago

Hey @hlolli,

That's awesome to hear that firefox works pretty seamlessly. And thanks for opening a PR.

I'm curious what was the problem with dependency conflicts that you were seeing so I can keep an eye out for that in the future. It looks a bit arbitrary to me to not use the latest ring-jetty-adapter version. Unless I'm missing something else.

Thanks, Jeff

hlolli commented 6 years ago

Yes, I mistakenly thought this was the newest version. I've added yet another commit, and can squash them if wanted.

jeffh commented 6 years ago

Thanks @hlolli!