bluesky_load() argument names

[jonathancallahan]

Elsewhere at AirFire we have adopted the following names:

• modelName -- e.g. "CANSAC-1.33km"
• modelMode -- e.g. "forecast"
• modelVersion -- e.g. "1.2.1"
• modelRun -- e.g. 2020051612 or "2020051612"

We should use the same naming scheme in bluesky_load() and throughout the AirFireModeling package.

This will require updating many (most?) files in the R/, vignettes/ and tests/ subdirectories with the following changes:

• [x] model ==> modelName
• [x] modelType ==> modelMode
• [x] modelRun ==> modelRun (stays the same)
• [x] (not used) ==> modelVersion

This can be done manually (slow) or by using SublimeText to make changes across all files at once. Sublime can probably be used to change "modelType" to "modelMode" because "modelType" is pretty unique. But changing "model" to "modelName" will probably have to be done by hand.

I recommend using grep when you are done to make sure you've found everything.

Make sure to Check and Build before pushing the code changes. Use MazamaCoreUtils::check_slow() to make sure all examples are tested.

This task is complete when all names have been changed and the package builds with no errors, warnings or notes.

[tabrasel]

Can you elaborate on modelVersion? Is this a new parameter that should be added to each function?

[jonathancallahan]

There isn't anything for you to do right now with modelVersion. You may check that box!

This is used as an argument in some scripts based on the AirFireModeling package that insert it into a database field.

It's good that you asked because I think we should both keep it around in the back of our minds, but I don't think we have any need for it in the code at the moment.