MazamaScience / AirFireWRF

Utilities for working with WRF atmospheric model data
https://mazamascience.github.io/AirFireWRF/
0 stars 1 forks source link

making plotting WRF-specific #19

Closed jonathancallahan closed 4 years ago

jonathancallahan commented 4 years ago

This isn't a precisely defined task but I feel the various plot_~() and layer_~() functions (or some new ones) need some changes to make them more user friendly in the context of working with WRF output.

Here are some specific suggestions for the layer_~() functions:

And I'm not thrilled about a new "class" of objects implied by the plot_~() functions. Instead, I think these should be functions/methods associated with the somewhat abstract wrf_ objects -- basically just a RasterBrick full of WRF output variables.

Some suggestions for the plot_~() functions (now renamed as wrf_~() functions:

tabrasel commented 4 years ago

wrf_basePlot() is always called by higher-level functions like wrf_rasterPlot() or wrf_standardPlot(), which are actually given the rasters from which we can extract their titles. So I think it is better to set the title of the plot within the higher-level function and just passing that string down to wrf_basePlot().