jonathancallahan
commented
4 years ago I'm not sure this is a good idea.
The createTibble() step uses box filtering to get the minimum bounds in
curvilinear coordinates that will contain the rectilinear bounding box. But
this can include lots of grid cells that are outside of the requested
bounding box. So the secondary filtering is still necessary once we have
the tibble in rectilinear space.
On Mon, Nov 18, 2019 at 10:35 AM Roger Andre notifications@github.com wrote:
Remove the bbox fitering in spatial points, as it's not needed anymore with bbox filtering taking place in the createTibble step. Just need to pass the bbox input param into createTibble and remove all the lat/lon evaluation logic from createSpatialPoints()
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MazamaScience/MazamaSatelliteUtils/issues/69?email_source=notifications&email_token=AAFYN5LT7Q2H5PUYG5PGTYDQULOATA5CNFSM4JOYLE42YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H2D5DZQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFYN5PROP5W2C4TR6RXETTQULOATANCNFSM4JOYLE4Q .
-- Jonathan Callahan, PhD Mazama Science 206-708-5028 mazamascience.com
Remove the bbox fitering in createSpatialPoints(), as it's not needed anymore with bbox filtering taking place in createTibble(). Just need to pass the bbox input param into createTibble() and remove all the lat/lon evaluation logic from createSpatialPoints()