While it's convenient that the goesaodc_createScan*()functions allow you to specify a scan by either sat+time info or filename, this is another place where it might be better to separate behavior rather than have one function handle everything and hope the user will remember the different input modes. I think this refactor should make the general GOES workflow a little less confusing:
goesaodc_listScanFiles(): Should take in satellite + time info and returns a vector of scan filenames that fit the request. This function already does that, so no changes need to be made here.
goesaodc+createScan*(): Should take in only scan filenames and create SPDFs or rasters from them.
While it's convenient that the
goesaodc_createScan*()functions allow you to specify a scan by either sat+time info or filename, this is another place where it might be better to separate behavior rather than have one function handle everything and hope the user will remember the different input modes. I think this refactor should make the general GOES workflow a little less confusing: