MazamaScience / PWFSLSmoke

Utilities for working with air quality monitoring data (e.g. federal regulatory monitors)
http://mazamascience.github.io/PWFSLSmoke/
GNU General Public License v3.0
19 stars 5 forks source link

monitor_filter() function #71

Open jonathancallahan opened 5 years ago

jonathancallahan commented 5 years ago

The monitor_subset() function is very "base R" in its usage. Having arguments stateCodes = c('WA','OR') feels wrong when you are used to dplyr style.

We do have a monitor_subsetBy() function which actually harness dplyr::filter() applied to ws_monitor$meta.

We should deprecate that name in favor of monitor_filter() and write a bunch of unit tests for it to make sure it behaves properly. I think we should keep the data = functionality as best we can.

Please note that these functions should be implemented without using monitor_toTidy() which inflates the size of data in memory by a factor of 10-20.