search

Mazamars312 / openfpga-pcengine-cd

The openFPGA PCECD Core
GNU General Public License v2.0
52 stars 4 forks source link

(Readme issue) JSON manual mode creation's tutorial mistake (didn’t resolve yet) #25

Closed MelonGx closed 1 year ago

MelonGx commented 1 year ago

JSON Manual mode creation in the assets\pcecd\Mazamars312.PC Engine CD\ folder there a image_template.json file. depending on how many BIN files files is how many dataslots you use and folder location. "data_path": "image/", is the folder location in the \Assets\pcecd\common\ folder

I firstly wrote "image/tokimeki/" to direct \Assets\pcecd\common\tokimeki\ , but failed to boot. Then I modified it to "tokimeki/" to direct \Assets\pcecd\common\tokimeki\ , successfully booted. So I think the correct data path of "image/" should be \Assets\pcecd\common\image\ but not \Assets\pcecd\common\ , which means the description I quoted is wrong.

Mazamars312 commented 1 year ago

This was for the json file as you have to write them for this. So the document is correct for that part,

MelonGx commented 1 year ago

No. You don’t give me a proper explanation why you insist “image/“ = “assets/pcecd/common/”.

Because the fact is “Tokimeki/“ = “assets/pcecd/common/Tokimeki/“ which means “image/“ should be = “assets/pcecd/common/image/“.

NeitherMeNorYou commented 1 year ago

I would personally suggest changing the sentence to help with readability for people that have to rely on machine translation, and don't want to use one of the updaters.

My suggestion would be the following:

"data_path": "image/", replace "image" with the name of the folder that contains the bin+cue files. The folder must be located in \Assets\pcecd\common\

MelonGx commented 6 months ago

My suggestion would be the following:

"data_path": "image/", replace "image" with the name of the folder that contains the bin+cue files. The folder must be located in \Assets\pcecd\common\

Your explanation is acceptable although I still felt a little bit hard to get what you exactly meant. But the author adopted nothing and still left it wrong.