search

Mazamars312 / openfpga-pcengine-cd

The openFPGA PCECD Core
GNU General Public License v2.0
60 stars 6 forks source link

Missing `parameters` in "CDROM II Bios" data slot #53

Open neil-morrison44 opened 9 months ago

neil-morrison44 commented 9 months ago

Hey, Just putting this here so it's tracked for the next time you're packaging up this core.

The slot currently says:

    {
    "name": "CDROM II Bios",
    "id": 1,
    "required": true,
    "filename": "bios_3_0_usa.pce",
    "alternate_filenames": ["bios_3_0_jap.pce", "bios_2_0_usa.pce", "bios_2_0_jap.pce", "bios_1_0_usa.pce", "bios_1_0_jap.pce"],
    "extensions": [
        "pce"
        ],
    "address": "0x10000000",
    "size_maximum": "0x40000"
    },

without a parameters - which seems to work fine on the Pocket itself since (I presume) it's defaulting to 0 - but I think it's technically required by the OpenFPGA spec (though the spec isn't great at pointing out what's actually optional).

(...and also Pocket Sync had an issue with it, but there's a fix in that just defaults it to 0 as well)