Apply CMake fixes from Mbed TLS

Mbed-TLS / TF-PSA-Crypto

Reference implementation of the PSA Cryptography API

Apache License 2.0

8 stars 7 forks source link

Apply CMake fixes from Mbed TLS #38

Closed davidhorstmann-arm closed 11 months ago

davidhorstmann-arm commented 1 year ago

Fixes #21

Apply fixes from Mbed TLS to PSA Crypto's CMake files.

This includes all relevant CMake changes from Mbed TLS, since the PSA Crypto repository was forked, except for:

Changes related to generating mbedcrypto tests, as these tests are not yet in PSA Crypto (see #35).
Changes related to IAR support, which is not yet available in this repo.

ronald-cron-arm commented 1 year ago

After a first quick look, I think as we have support to generate tests PSA crypto APIs tests as in mbedtls we should also add the support for the bignum and ecp tests that were added after the creation of the psa-crypto build system.

davidhorstmann-arm commented 1 year ago

After a first quick look, I think as we have support to generate tests PSA crypto APIs tests as in mbedtls we should also add the support for the bignum and ecp tests that were added after the creation of the psa-crypto build system.

Right, yes. I noticed these changes when I was going through them, but I figured that it would be better to add them as part of #35 since the are test-related.

ronald-cron-arm commented 1 year ago

After a first quick look, I think as we have support to generate tests PSA crypto APIs tests as in mbedtls we should also add the support for the bignum and ecp tests that were added after the creation of the psa-crypto build system.

Right, yes. I noticed these changes when I was going through them, but I figured that it would be better to add them as part of #35 since the are test-related.

Fine by me to do it in #35

davidhorstmann-arm commented 1 year ago

(Force-pushed to remove final commit, which belongs in #35).

ronald-cron-arm commented 12 months ago

I have been through that and I would say that we could get the changes done in cb33076353 that are not there yet.

Agreed to do that in a follow-up issue as it needs to rework the lcov.sh script in Mbed TLS repo.

davidhorstmann-arm commented 11 months ago

Force-pushed to remove reference to Everest from the last commit message - discussed offline with @paul-elliott-arm.