search

Mbed-TLS / mbedtls-docs

Version-independent documentation for Mbed TLS
Apache License 2.0
21 stars 28 forks source link

Document the review process for contributors #93

Closed mpg closed 1 year ago

mpg commented 1 year ago

I've written parts of this document dozens of time over the years as github comments on someone's PR, and I'm sure I'm not alone. Let's get this properly documented.

jethrogb commented 1 year ago

This should probably be linked from https://github.com/Mbed-TLS/mbedtls/blob/development/CONTRIBUTING.md

mpg commented 1 year ago

This should probably be linked from https://github.com/Mbed-TLS/mbedtls/blob/development/CONTRIBUTING.md

Absolutely. https://github.com/Mbed-TLS/mbedtls/pull/7468

mpg commented 1 year ago

Ironically, I found myself force-pushing several times in a row because I couldn't seem to get things right for the DCO check. The commit you previously reviewed was 455f9d806030efd96e058d8370f249d36a220190. I believe I have not altered its content, just the commit message.