Mbed-TLS / mbedtls-test

MbedTLS testing
Apache License 2.0
4 stars 24 forks source link

Make it easier to manually trigger CI runs on third party PRs #135

Open bensze01 opened 12 months ago

bensze01 commented 12 months ago

Currently triggering a manual CI run on third party PRs requires a developer to navigate to various pages of the Classis Jenkins UI and search for the PR by its number, then click the "Launch new build" button. This issue gathers some options we could implement to make this user experience better.

Ordered from easiest to implement to hardest to implement:

tom-cosgrove-arm commented 12 months ago

Needs extra logic to associate with commit hash

For both of these, can't it just be based on timestamps, i.e. special comment or approval that is more recent than the commit, and CI hasn't run on that commit? i.e. all we want to do is avoid running the CI on a commit that is newer than the comment or the approval

gilles-peskine-arm commented 12 months ago

Triggering the CI build using a specially formatted developer comment

This has my preference. It doesn't involve any navigation of CI systems. It means I don't need to be on the internal Arm network to start on the internal CI. It makes the association between the approved commit ID and the commit ID that the CI will pick straightforward.

Manual copying of hash by developers seems cumbersome

It's easy to grab the hash from the github interface. Just please allow copy-pasting the whole URL.