Open gilles-peskine-arm opened 1 year ago
Is the issue going to close itself when the associated PRs are closed?
Only if the pull request is linked using a keyword in the issue description (or otherwise). Which I guess we should do in the CMAC PR.
Thanks for the info, linked HMAC and CMAC
This is one step on the way to https://github.com/Mbed-TLS/mbedtls/issues/7801 — see the issue for the long-term goal.
The goal of this issue is to set up some testing for the built-in implementation of MAC operations, and in particular cover the size of the output buffer. Generally speaking, use the same strategy as https://github.com/Mbed-TLS/mbedtls/pull/7803:
crypto_data_tests.py
to do HMAC calculations.test_suite_psa_crypto_low_mac
with test code for one-shot and multipart operations, including testing with a larger output buffer for the MAC.mbedtls_psa_mac_compute
andmbedtls_psa_mac_finish
to work when the output buffer is larger than the actual output (see https://github.com/Mbed-TLS/mbedtls/pull/7700#discussion_r1233989185).Follow-up: CMAC