PSA always enabled in 4.0

Mbed-TLS / mbedtls

An open source, portable, easy to use, readable and flexible TLS library, and reference implementation of the PSA Cryptography API. Releases are on a varying cadence, typically around 3 - 6 months between releases.

https://www.trustedfirmware.org/projects/mbed-tls/

Other

5.25k stars 2.56k forks source link

PSA always enabled in 4.0 #8147

Closed daverodgman closed 1 week ago

daverodgman commented 1 year ago

[x] MBEDTLS_USE_PSA_CRYPTO must be removed from mbedtls_config.h. The library must behave as if it was always enabled. → https://github.com/Mbed-TLS/mbedtls/issues/9630
[x] For supported cases, at least one of MBEDTLS_PSA_CRYPTO_C / MBEDTLS_PSA_CRYPTO_CLIENT must be always enabled. Disabling both would be needed for people who want an alternative PSA impl (this would not be a supported/validated case) → https://github.com/Mbed-TLS/mbedtls/issues/9630
[x] MBEDTLS_PSA_CRYPTO_CONFIG must be removed, and treated as always-enabled. → https://github.com/Mbed-TLS/mbedtls/issues/8153
[x] Identify dead code (ie code guarded by #if !defined that can never be built). Create tasks to remove this code. → https://github.com/Mbed-TLS/mbedtls/issues/9631 + https://github.com/Mbed-TLS/mbedtls/issues/8153
[ ] Optionally, remove some/all of the dead code identified in the previous step

daverodgman commented 1 year ago

See #5156 for earlier discussion on this

mpg commented 11 months ago

I think we also want to identify test code that becomes redundant. For example, a lot of things are tested both with and without USE_PSA_CRYPTO, quite a few things tested with PSA_CRYPTO_C disabled, etc.

My gut feeling is that this task is larger than M - it's the kind of thing that looks easy on paper but where you tend to run into surprises. So, I'd be inclined to split it into smaller tasks - I think the first three items could be one task each.

Also, I agree with leaving some parts (remove dead code) to follow-up tasks but I'd strongly advise we address those tasks ASAP. One of the expected benefits of this work is to make maintenance easier, and we don't fully get that while there's still a lot of dead code around.

gilles-peskine-arm commented 1 week ago

I think we also want to identify test code that becomes redundant

Test code will be removed when we remove dead code, based on searching for #if defined and requires_config_enabled and the like. Test cases will be identified by outcome analysis, thanks to https://github.com/Mbed-TLS/mbedtls/pull/9593.

gilles-peskine-arm commented 1 week ago

We have now created issues for each part, so this planning issue is completed.