Reject duplicated build steps in the outcome file

Mbed-TLS / mbedtls

An open source, portable, easy to use, readable and flexible TLS library, and reference implementation of the PSA Cryptography API. Releases are on a varying cadence, typically around 3 - 6 months between releases.

https://www.trustedfirmware.org/projects/mbed-tls/

Other

5.24k stars 2.56k forks source link

Reject duplicated build steps in the outcome file #9286

Open gilles-peskine-arm opened 3 months ago

gilles-peskine-arm commented 3 months ago

Resolves https://github.com/Mbed-TLS/mbedtls/issues/9023

Needs preceding PR to fix some issues in all.sh: https://github.com/Mbed-TLS/mbedtls/pull/9293

Status: work in progress, I want CI feedback

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

[x] changelog not required (test only)
[ ] 3.6 backport TODO
[ ] 2.28 backport TODO
[x] tests provided

tom-cosgrove-arm commented 3 months ago

Note "Reject duplicated build steps in the outcome file" seems very different from "use .s for assembly files" - presumably the latter could be a separate PR, making everything easier to review?

gilles-peskine-arm commented 3 months ago

@tom-cosgrove-arm You're right, this turned into “fix issues in all.sh”, mostly so that I could have distinct configuration names. I'll break that unexpected part out.

gilles-peskine-arm commented 3 months ago

I've split out the all.sh preliminaries into https://github.com/Mbed-TLS/mbedtls/pull/9293