search

Mbed-TLS / mbedtls

An open source, portable, easy to use, readable and flexible TLS library, and reference implementation of the PSA Cryptography API. Releases are on a varying cadence, typically around 3 - 6 months between releases.
https://www.trustedfirmware.org/projects/mbed-tls/
Other
5.24k stars 2.56k forks source link

analyze_outcomes: inconsistent ordering of driver vs reference #9298

Closed gilles-peskine-arm closed 3 weeks ago

gilles-peskine-arm commented 3 months ago

Sample error from analyze_outcomes.py on driver-vs-reference comparison:

*** Analyze driver test_psa_crypto_config_accel_cipher_aead_cmac vs reference test_psa_crypto_config_reference_cipher_aead_cmac ***

Error: PASS -> SKIP/FAIL: ssl-opt;TLS: password protected server key, two certificates

The header line says “driver vs reference” but the error line says “reference -> driver”. This is misleading. We should use a consistent order, either driver-then-reference or reference-then-driver. @mpg Do you have any preference?

mpg commented 3 months ago

Ah, right, I hadn't considered that. I don't have a strong preference, anything's fine with me as long as it's clear(er than the existing).