McArcady / lnp-forge

A Dwarf Fortress starter pack builder for Linux & MacOS
Other
239 stars 19 forks source link

Add CI #18

Closed corollari closed 4 years ago

corollari commented 4 years ago

The major contribution of this PR is a CI system that, on every new commit or PR, will:

I hope that this will help prevent the following problems, which I found when building the pack by myself:

Apart from all this, this PR changes autoconf to use python3 instead of the default python command provided by each specific distro. This may seem like a minor change but it helps a lot if your distribution defaults to python2, which causes the autoconf script to trigger an error saying that the tkinter module cannot be found, while python is reported to be fine. This happened to me when building on ubuntu 18.04 and it lead to a lot of hair pulling, as I kept focusing on trying to debug why was the tkinter not being properly installed when it was actually properly installed. The reason why autoconf failed in this specific case is that the check on the availability of the tkinter package uses the code python -c "import tkinter" 2>/dev/null, which works for python3 but doesn't for python2 due to the fact that the tkinter module in python2 is Tkinter.

On a final note, you may want to add the module python3-tk to the list of dependencies (as mentioned in #11) because the tk dependency that is currently included, python-tk, is for python2.

McArcady commented 4 years ago

Very nice. Thank you for taking time to set up this: