search

McArcady / lnp-forge

A Dwarf Fortress starter pack builder for Linux & MacOS
Other
240 stars 18 forks source link

Soundsensers linux #55

Closed DHMike57 closed 2 years ago

DHMike57 commented 2 years ago

Fix for the linux webkit problem of 'can't find variable external' resulting in ui unresponsive to mouse clicks. See issue at soundsense-rs repository. Needs rust compiler to rebuild from source.

McArcady commented 2 years ago

Good idea! Soundsense-RS seems unmaintained, so it's a good thing if we provide major patches through lnp-forge.

BTW, would you know how to solve this build error (I'm not familiar with cargo and rust): error: the lock file .build/src/soundsense-rs-v1.5.1/Cargo.lock needs to be updated but --locked was passed to prevent this

DHMike57 commented 2 years ago

BTW, would you know how to solve this build error (I'm not familiar with cargo and rust): error: the lock file .build/src/soundsense-rs-v1.5.1/Cargo.lock needs to be updated but --locked was passed to prevent this

Sorry, I don't know much about it either - it just built for me with cargo v1.53.0! One thing I notice: I had the version in .config set to 'master' when it worked for me, and I did quite a few runs from scratch: I would have expected your ".build/src/soundsense-rs-master/..."

Edit: Tried it with version=v1.53.0 & got the same error, repeated with version=master & compiled successfully.

Unfortunately the prix repository has 350MB of deleted soundpack in the history which makes cloning it a PITA. I made a cleaned-up version, but it broke the fork connection.

Finally, sorry about the two-part PR: I'm not very experienced at this!

Mike

Podesta commented 2 years ago

Unfortunately the prix repository has 350MB of deleted soundpack in the history which makes cloning it a PITA. I made a cleaned-up version, but it broke the fork connection.

You can always clone with --depth=1. But yeah, the optimal would be changing the history, and removing the offending files/commits, but I'm not sure if that would also break fork connection.

McArcady commented 2 years ago

Thanks again for the patch but I cannot get it to build on my Debian. Too many unsolvable missing dependencies... Let's hope someone takes up the maintenance of Soundsense-RS.

DHMike57 commented 2 years ago

Unfortunately the prix repository has 350MB of deleted soundpack in the history which makes cloning it a PITA. I made a cleaned-up version, but it broke the fork connection.

You can always clone with --depth=1. But yeah, the optimal would be changing the history, and removing the offending files/commits, but I'm not sure if that would also break fork connection.

Good solution (to this very superficial git user anyway!). 'Breaks the fork connection' was ill chosen: the connection remains, but the PR was unusable because of the huge number of history changes that it incorporated. Perhaps there is a way to get around this with a deeper understanding of the innards of git.

DHMike57 commented 2 years ago

I think I have a fix for the build failure: web-view is updated to v0.7 in Cargo.toml , and you must compile without the --locked flag. It compiles for me on arch, but I also got it to compile on the github ubuntu-latest, where the original version with v0.6 failed.

DHMike57 commented 2 years ago

After a crash course in github workflows I think this is finally working: the build workflow completes without errors in my fork branch. The missing dependencies are 

- libasound2-dev  
- libgtk-3-dev 
- libwebkit2gtk-4.0-dev

in ubuntu and hopefully in other debian systems. Fingers crossed!