search

McArcady / lnp-forge

A Dwarf Fortress starter pack builder for Linux & MacOS
Other
240 stars 18 forks source link

Remove invalid '-' char in arch version string #56

Closed DHMike57 closed 2 years ago

DHMike57 commented 2 years ago

Arch linux package causes pacman errors because '-' is not a valid char in version string.

McArcady commented 2 years ago

Thanks for the patch. The problem is that in its current form, it changes the name of all packages (rpm, deb, ... etc), not only the AUR one. That should be easy to fix though.

If I understand correctly the purpose, AUR expects the package name to be: linux-dwarf-pack-0.47.05.r1-1-x86_64.pkg.tar.bz2 (dot before r1) instead of: linux-dwarf-pack-0.47.05-r1-1-x86_64.pkg.tar.bz2 (hyphen before r1) ?

DHMike57 commented 2 years ago

Thanks for the patch. The problem is that in its current form, it changes the name of all packages (rpm, deb, ... etc), not only the AUR one. That should be easy to fix though.

If I understand correctly the purpose, AUR expects the package name to be: linux-dwarf-pack-0.47.05.r1-1-x86_64.pkg.tar.bz2 (dot before r1) instead of: linux-dwarf-pack-0.47.05-r1-1-x86_64.pkg.tar.bz2 (hyphen before r1) ?

Yes, dot before r1 works (also eg .rc3-blah-blah-...) The incorrect version will install and actually work, but it is very irritating because every subsequent use of the package manager generates a scary and unhelpful warning.

McArcady commented 2 years ago

Please could you check option “Allow edits from maintainers.” so that I can modify the PR? (also for the other one)

DHMike57 commented 2 years ago

Please could you check option “Allow edits from maintainers.” so that I can modify the PR? (also for the other one)

I think this is checked in both (just underneath the 'n participants' section)