McCloudS / subgen

Autogenerate subtitles using OpenAI Whisper Model via Jellyfin, Plex, Emby, Tautulli, or Bazarr
MIT License
570 stars 49 forks source link

Non-cuda dockerfile has cuda image #41

Closed lyfenwebos closed 8 months ago

lyfenwebos commented 8 months ago

So I wanted to use docker container and I noticed that recently non-cuda docker container was probably non intentionally swapped to the cuda image. https://github.com/McCloudS/subgen/blob/main/Dockerfile#L1

McCloudS commented 8 months ago

It was done on purpose to simplify building. While it will be slightly larger on download, it shouldn’t impact anything. Some of the packages even in CPU only required cuda packages resulting in minimal space savings. Let me know if there are issues.

On Sun, Jan 28, 2024 at 1:14 PM Pavel Gontsarov @.***> wrote:

So I wanted to use docker container and I noticed that recently non-cuda docker container was probably non intentionally swapped to the cuda image. https://github.com/McCloudS/subgen/blob/main/Dockerfile#L1

— Reply to this email directly, view it on GitHub https://github.com/McCloudS/subgen/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/APJACQNMWW26LLKTF4B3UGLYQ2WQHAVCNFSM6AAAAABCONNR4GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGEYDIMZTGAZDMNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

lyfenwebos commented 8 months ago

So setting TRANSCRIBE_DEVICE: "cpu" should be enough to use cpu? In my case it still tries to use cuda

lyfenwebos commented 8 months ago

Or it is okey that it is trying to load cuda, fails and throws an info/debug(?) message? Below this debug message about cuda not available I have this block File "/subgen/./subgen.py", line 21 import ffmpeg-python SyntaxError: invalid syntax

McCloudS commented 8 months ago

Thank, I’ll take a look. The default behavior should fail to CPU if no GPU is found. What does it look like it’s doing?

McCloudS commented 8 months ago

Yeah, I’m troubleshooting that ffmpeg line now. Sorry for the inconvenience.

lyfenwebos commented 8 months ago

Okey, then I suppose it is a duplicate and I'll be following regarding this in the neighboring issue

McCloudS commented 8 months ago

Confirmed that if no GPU is found, it will default to CPU without issue.