search

McDermott-Group / servers

Public repo that stores LabRAD servers and other non-measurement related code
0 stars 2 forks source link

Remove all code that was used for debugging #53

Closed patzinak closed 8 years ago

patzinak commented 8 years ago

There are lots of code chunks that are commented out and likely were used for debugging. Remove them out (preferably) or write a comment regarding the potential need for this commented code.

patzinak commented 8 years ago

For example, lines 70, 73, 103, 107-112, 114, 129-132, 262-269, 280-284 in servers/GUI/mView/NotifierGUI.py

nmGit commented 8 years ago

I can suppress output and remove a lot of the code for debugging, but I hesitate to remove it all because the code is still under active development and will be for a long time. The debugging code is extremely useful for quickly fixing bugs.

patzinak commented 8 years ago

print("here") is not a useful debugging feature... But sure, keep important logical blocks (or create a new branch when you adding a totally new feature). It is okay to have commented something like this: print("Number of servers running: %d", number_of_servers) because this statement indirectly tells you what is important at this point of the code execution, it is a some sort of a comment. But print('working') is no okay.

nmGit commented 8 years ago

All extra debugging code removed.