McGill-CSB / PHYLO

a gaming framework to align genomic data
phylo.cs.mcgill.ca/edge
Other
11 stars 14 forks source link

Registration doesn't explain what is wrong when validation of email or password fails #116

Closed movermeyer closed 6 years ago

movermeyer commented 6 years ago

Steps to reproduce:

  1. Click Register
  2. Enter a valid username and email
  3. Enter a password (ex. "SomeSimplePasswordUntilTheyFixPaste")
  4. In the password confirmation box, type a similar (but typoed) password (ex. "SomeSimplePasswordUntilTheyFixPastr")

The error message says "Please fix error in field below".

It does not explain which fields need changing, nor why they need changing. Ideally, the password confirmation field would be highlighted in red, and the error message would say something like "Password and Confirm Password fields do not match"

Visually:

register

Similarly, if you enter an invalid email address (ex. "a"), the email field should be highlighted, and the error message should be something similar to "Invalid email address".

You already give a nice error message when the username already exists, so the code for custom messages is already in place. Hopefully, it's a simple matter to extend it to these cases too.

Tested on: Phylo (Web) v1.1.7.7? Or it 2.0.1? 2.0.1 is what the McGill loading page says, but the top of the site says 1.1.7.7

waldispuhl commented 6 years ago

Thanks. We need to fix this indeed.

The version# on the webpage will be removed soon. the right version# is the one of the app.

chrisdrogaris commented 6 years ago

Hi movermeyer

We have fixed the issue on the latest version on this link: https://phylo.cs.mcgill.ca/play.html

I have also attached a screenshot

registration-bug-fixed

Thanks for the feedback.