McGill-CSB / PHYLO

a gaming framework to align genomic data
phylo.cs.mcgill.ca/edge
Other
11 stars 14 forks source link

PHYLO sends user passwords in plaintext; should be using TLS #118

Open movermeyer opened 6 years ago

movermeyer commented 6 years ago

PHYLO is not using encryption (ie. TLS). This has been an increasingly dangerous thing for websites to do, as user details are being sent in plaintext across the internet.

This allows third parties to collect the user details which can be used to compromise other online accounts of the >60% of users who re-use their passwords across multiple sites.

Beyond that, we have seen nation-states take advantage of non-TLS connections in order to perform man-in-the-middle attacks on users, which can harm both the users and the reputation of the site.

This is all to say that encrypting connections to websites has become table stakes for being secure on the web.

From Fiddler 4:

POST http://ec2-52-26-53-11.us-west-2.compute.amazonaws.com/api/login/ HTTP/1.1
Host: ec2-52-26-53-11.us-west-2.compute.amazonaws.com
User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Accept: */*
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Referer: http://phylo.cs.mcgill.ca/
Content-Type: application/x-www-form-urlencoded
Content-Length: 34
Origin: http://phylo.cs.mcgill.ca
DNT: 1
Connection: keep-alive

username=MyUsername&password=MySecurePassword

More reading:

movermeyer commented 6 years ago

This applies to

waldispuhl commented 6 years ago

Thanks. We are indeed planning to use TSL. We're working on it but are experiencing compatibility issues. Hopefully it'll be fixed soon.