McGill-ECSE321-Winter2021 / project-group-09

project-group-09 created by GitHub Classroom
2 stars 6 forks source link

addHoliday reiview changes pleaase #190

Closed zhannaklimanova closed 3 years ago

zhannaklimanova commented 3 years ago

I agree with Jacek's comments. I saw that you created a blank page for View Holidays. Are you going to create a separate page for "View Holidays"?

  • All tests pass (Repository & Service)
  • Everything seems to work perfectly 💯 👍🏼

Testing

Adding Holiday (After logging in as Admin)

image

From Postman (Get All Holidays)

image

@sandyl289 Yea, so Tyler and I were talking about it and he said that you're working on the display holidays page and that I should move on to viewing/deleting appointments for technicians from the admin account. But If you would like, I can try doing the display holiday thing.

sandyl289 commented 3 years ago

I agree with Jacek's comments. I saw that you created a blank page for View Holidays. Are you going to create a separate page for "View Holidays"?

  • All tests pass (Repository & Service)
  • Everything seems to work perfectly 💯 👍🏼

Testing

Adding Holiday (After logging in as Admin)

image

From Postman (Get All Holidays)

image

@sandyl289 Yea, so Tyler and I were talking about it and he said that you're working on the display holidays page and that I should move on to viewing/deleting appointments for technicians from the admin account. But If you would like, I can try doing the display holiday thing.