Review script shard compliance

[McHale]

Review scripts that could easily be modified to be compliant with shard rules.

I tend to prefer making scripts that require the player to be watching the screen. An example of this is the beeApp. If the player is out of a particular potion or tool, I do not write the script to auto grab more. I leave this to the player to ensure that the script will not auto complete a task in its entirety.

The other way to accomplish this is simply to break a task into its individual actions that may require several clicks or more. Create buttons as appropriate, but not auto chain them script wise. The player will only have to click one button to accomplish a set of clicks for an action, but the scripted task should require the player to only have to press a few buttons.

[Themadxcow]

I am currently writing a menu overlay for the scripts I have uploaded. I am still fairly new to this, so I apologize for any errors I make. I also want to make sure I understand the intent of each lib in order to help with optimization. My reduction is below:

Basiclib -- mostly an unused duplicate of itemlib. Contains a few basic functions (port to functionslib) seed_looter -- not a lib, possibly integrate with looter.lua bodlib == bodlibv2, integrate with tamingbodlib journallib == (kal)journalv2lib

Hopefully I am not too far on understanding the code here. My main concern is with basiclib/itemlib/functionlib . I propose redefining basiclib as resourcelib containing ids and types for resource gathering (trees, rocks, water etc).

[McHale]

Basiclib - you are correct,, it is most unused duplicates of the itemlib, both were written by jack penny. (i mostly used it for some basic clicking functions, that would otherwise act up -- port used functions to functions.lua) ItemLib - I have made some of my own modifications bodlib was a conglomerate of both the tamingbodlib and the bodlibv2 (I want them completely separate actually)

basiclib should be redefined as resourcelib (i would look into the code for the actually game, i sawsome lists with id types that can be intergrated versus collecting this data yourself)

functions.lua is more general -- there are several things I would actually like to move in there, any common and duplicated code that i have across my scripts. --Functions that allow you to have the player click any particular item for use in a script (I use the item identification skill to have the target pop up) --Functions that allow you to have the player click any particular container (i'm imagining in the resourcelib.lua lists of commonly related items, doors, containers, flowers, etc) one of these could be passed into the function as a check. Either a list or a specific item type.