McJtyMods / AquaMunda

Aqua Munda is a mod about water and purification
MIT License
3 stars 3 forks source link

[Question/Bug?] Seeds pop up when not using fresh water #20

Closed davqvist closed 6 years ago

davqvist commented 7 years ago

MC 1.12.1 Forge 2460 AM 0.1.2beta

I wonder if it is intentional that seeds that are planted on AM Farmland pop up when not supplied with fresh water nearby. This happens whenever there is a block update, meaning when I plant a seed adjacent to another plant of if a growth tick is applied.

McJty commented 7 years ago

What config option did you pick for the farmland mode?

davqvist commented 7 years ago

S:farmlandOverhaulType=fresh

But I thought this only affects growth speed and not popping off for seeds.

McJty commented 7 years ago

I will check out the exact details soon

McJty commented 7 years ago

When no fresh water is available the farmland will turn into dirt and then seeds will pop off. Is that what happens?

davqvist commented 7 years ago

No, it is still Farmland. What I expect to be happening is, that when nothing is planted on Farmland and is not watered it gets turned into dirt, but when a seed is planted, it just grows very slowly. This is the same behavior as in vanilla when farmland is not provided with any water nearby.

McJty commented 7 years ago

I will investigate

davqvist commented 7 years ago

Not sure if it helps but you can see it in action here: https://www.twitch.tv/videos/169003744 starting from 2:55:00 My assumption: Some seeds as Hemp cause a Block update which causes the seeds to pop off. As even the vanilla seeds pop off later (couldn't find the timeframe right now), I assume this is caused by a growth tick.

McJty commented 7 years ago

I'm working on Aqua Munda again but I cannot reproduce this problem in my dev env

davqvist commented 7 years ago

Definitely happens wirh modded seeds, did you try with Hemp from IE?

McJty commented 7 years ago

Well perhaps the modded seeds cannot cope with the fact that Aqua Munda overrides farmland with a custom block. In any case there will be a config option next version to not do that (but with more limited Aqua Munda experience in that case)

davqvist commented 7 years ago

Okay, I tested it, couldn't replicate with Hemp anymore for some weird reason, but could definitely replicate with vanilla beetroot. Can you investigate again?

McJty commented 7 years ago

Well that test I already did. Exactly what is your setup?

davqvist commented 7 years ago

I can definitely replicate in 0,2 again. I just place 2 dirt, hoe them and place two beetroot seeds in both AM Farmland. As soon as I place the second seed, both pop off. I will test in an environment with only AM at a later time, but in my WIP pack it happens every time.

McJty commented 7 years ago

How much light does the farmland get?

davqvist commented 7 years ago

I didn't check, will do, but I doubt that was the problem as I tested at day under open sky.

McJty commented 7 years ago

Well clueless... I cannot reproduce this at all

davqvist commented 7 years ago

I created a new instance, Forge 2474. I only added JEI, The One Probe, ImmersiveCraft, Aqua Munda and also Botania, Baubles and Primal Core because I tested also something else. But Botania, Baubles and Primal Core were not in the old instance, so that for certain doesn't matter. I created a new world, cheated in a hoe, hoed two grass next to each other, cheated in some beetroot seeds, planted them and they popped off. Light was 15.

davqvist commented 7 years ago

I know you are busy with some awesome RFTools features, but were you able to investigate that further? Or do you need more info? I can replicate it constantly like described above.

McJty commented 7 years ago

At the moment no. I still was not able to reproduce it either

davqvist commented 7 years ago

I would still like to get this fixed. Any updates on it? Still happening even with vanilla Beetroot.

McJty commented 7 years ago

I cannot fix problems I cannot replicate. I have no clue how to go further on this to be honest

McJty commented 7 years ago

Can you show some screenshots? Also what config are you using for Aqua Munda?

davqvist commented 7 years ago

Config: https://pastebin.com/SzsyhVU7 Not sure how screenshots are better than the videos from above, but here you go: https://imgur.com/hRQMPlX

It confuses me how you are not able to reproduce it. I can replicate in a new world with only the few mods installed above. I am willing to help you with everything you need to know, just let me know what you want to have/know.

davqvist commented 7 years ago

Let me test in a fresh world with only AM

McJty commented 7 years ago

And you have a fresh water source nearby?

davqvist commented 7 years ago

No fresh water, but they still shouldn't pop off, right?

davqvist commented 7 years ago

Can confirm in fresh world with only JEI, TOP, ImmersiveCraft and Aqua Munda Forge 2556

McJty commented 7 years ago

Do they pop off if there is fresh water nearby? If not then that's the reason

davqvist commented 7 years ago

Well, that is the whole point of the issue as you can see in the title. That they pop off without fresh water. Other vanilla plants don't do that, only Beetroot or some other modded seeds.

davqvist commented 7 years ago

Anyway, they pop off even with Fresh Water fwiw

davqvist commented 7 years ago

https://imgur.com/1JFrciy

McJty commented 7 years ago

Ok, I can reproduce it now. Seems it only happens if you plant seeds next to each other. If you give them room they don't pop off Not sure why though

davqvist commented 7 years ago

Yep exactly. I have no clue either. Has to be something Beetroot specific.

davqvist commented 7 years ago

If it helps, not being next to each other is the cause as written in the initial post, but rather a block update causes it.

McJty commented 7 years ago

I know what's wrong. Just have to come up with a good solution for this

davqvist commented 7 years ago

Awesome, thank you very much

McJty commented 6 years ago

Sorry for the slow response but this is fixed next release

davqvist commented 6 years ago

Excellent, thanks very much