McJtyMods / LostCities

MIT License
115 stars 66 forks source link

Stacking leave blocks in ancient profile #22

Open tyra314 opened 7 years ago

tyra314 commented 7 years ago

Hi,

in my tweaked ancient profile stacking leave blocks get generated next to buildings, which are they more worn than the leave would suggest.

Well a picture describes more than a thousands words could do: 2017-07-01_10 44 58 2017-07-01_10 48 06

Slightly related, sometimes you get a layer of air between the blocks and the buildings: 2017-07-01_10 58 00

Here is my adapted profile: https://gist.github.com/tyra314/aa3ce4d64c26dc719c1ff6ad9d1f0e14 I'm using 1.10.2 with 0.0.13beta

tyra314 commented 7 years ago

The leaves may even end up flying:

2017-07-01_12 12 55

McJty commented 7 years ago

I'll check these out. That gap is weird. Haven't seen that yet. I'll see if I can find that in any of my worlds

McJty commented 7 years ago

For the high leaf blocks I think you were using old ancient configs and didn't delete them when upgrading lost cities. The corrects value should be:

# Chance that leafblocks will be generated at the border of a building and a street [range: 0.0 ~ 1.0, default: 0.05]
S:randomLeafBlockChance=0.05

# Frequency of leafblocks as seen from the sides of buildings [range: 1 ~ 8, default: 6]
I:randomLeafBlockThickness=6

Can you check that these are correct?

tyra314 commented 7 years ago

I changed those values on purpose in the first place. However, changed them back and I think the problems persist, but you don't see them as explicit as with changed configs.

2017-07-01_22 03 32

2017-07-01_22 06 09

2017-07-01_22 11 35

Maybe rephrasing, what I think is the problem helps:

Those leaves at the walls of buildings should look like climbing plants, right? And in general climbing plants need something to climb on. Therefore, when the worldgen for example decides to gen a building even with ground, I wouldn't expect climbing plants to be generated. Instead bushes would work well.

Oh, and a random suggestion, I always mix different leaves - oak and jungle blend well in vanilla textures - and fences, such that they look like the trunk. :) Like this: 2017-07-01_22 58 31

McJty commented 7 years ago

Those variant leaf blocks are a cool idea. I will do that. I have not seen any of the other problems though