McJtyMods / LostCities

MIT License
115 stars 66 forks source link

[1.20.1] Crash when pregenerating a world using chunky #613

Open BetaSigmaOmega opened 8 months ago

BetaSigmaOmega commented 8 months ago

When using chunky to generate new chunks, the server will freeze and crash after generating ~200 chunks. Tried removing Lost Cities only, and it worked exactly as expected. Generated ~4000 chunks before I assumed it was working correctly and stopped it. crash-2024-03-18_01.26.03-server.txt latest.log debug.log

Using default profile. No custom buildings or assets of any kind. Lost Cities functions as expected without pregen. No crashes.

McJty commented 8 months ago

I don't know if I can do much about this I'm afraid. You should also report this to chunky. Might be that the problem is on their side

BetaSigmaOmega commented 8 months ago

I actually reported it to chunky first. They said to report it to you. 😅 Thank you for the swift response, though

pop4959 commented 8 months ago

Chunky doesn't add any code here - this is completely "vanilla" generation being done by the server. It's done this way intentionally to reduce the chance of mod conflict to essentially zero.

This may not be directly Lost Cities; it could be a combination of mods that aren't playing well together during world gen, but something is definitely stalling here and causing the server to crash.

Either way, a good start would probably be to at least test and see if this happens with only Lost Cities installed.

AngleNaris commented 7 months ago

Same issue here, and tested with only Lost Cities and chunky installed. Usually stcuk but not crash after chunky start a few minutes. https://logpaste.com/ZGLs6Wk1

lostcities-1.20-7.1.4 Chunky-1.3.136 Minecraft 1.20.1 Forge 47.2.20

#General settings
[profiles]
    #Block to put underneath a bed so that it qualifies as a teleporter bed
    specialBedBlock = "minecraft:diamond_block"
    selectedProfile = "customized"
    selectedCustomJson = "{\"cities\":{\"cityLevel3Height\":99,\"cityMinRadius\":50,\"cityAvoidVoid\":true,\"cityLevel1Height\":83,\"cityMaxRadius\":128,\"cityStyleThreshold\":-1.0,\"cityChance\":0.01,\"cityThreshold\":0.2,\"cityLevel0Height\":75,\"cityStyleAlternative\":\"\",\"cityPerlinInnerScale\":0.1,\"cityPerlinOffset\":0.1,\"cityLevel2Height\":91,\"oceanCorrectionBorder\":4,\"cityPerlinScale\":3.0},\"client\":{\"horizon\":-1.0,\"fogDensity\":-1.0,\"fogBlue\":-1.0,\"fogRed\":-1.0,\"fogGreen\":-1.0},\"explosions\":{\"explosionMaxRadius\":35,\"explosionMinRadius\":15,\"explosionMinHeight\":75,\"miniExplosionChance\":0.03,\"miniExplosionMaxHeight\":100,\"miniExplosionMaxRadius\":12,\"debrisToNearbyChunkFactor\":200,\"explosionChance\":0.02,\"explosionMaxHeight\":90,\"miniExplosionMinRadius\":5,\"explosionsInCitiesOnly\":true,\"miniExplosionMinHeight\":60},\"lostcity\":{\"highwaySupports\":true,\"ruinChance\":0.5,\"groundLevel\":71,\"railwayStationsEnabled\":true,\"buildingChance\":0.3,\"railwaysCanEnd\":false,\"buildingMaxFloorsChance\":6,\"bedrockLayer\":1,\"liquidBlock\":\"minecraft:water\",\"rubbleLayer\":true,\"buildingMinFloors\":0,\"seaLevel\":-1,\"rubbleDirtScale\":3.0,\"fountainChance\":0.05,\"dataCenterChance\":0.1,\"warning\":\"\",\"highwaySecondaryPerlinScale\":10.0,\"spawnNotInBuilding\":false,\"bridgeSupports\":true,\"worldStyle\":\"standard\",\"buildingMaxFloors\":8,\"avoidFoliage\":false,\"buildingMinCellars\":0,\"buildingFrontChance\":0.2,\"baseBlock\":\"minecraft:stone\",\"ruinMaxlevelPercent\":1.0,\"spawnBiome\":\"\",\"avoidWater\":false,\"building2x2Chance\":0.03,\"railwaysEnabled\":true,\"highwayRequiresTwoCities\":true,\"parkBorder\":true,\"editMode\":false,\"spawnCity\":\"\",\"randomLeafBlockChance\":0.1,\"rubbleLeaveScale\":6.0,\"vineChance\":0.1,\"highwayLevelFromCities\":0,\"highwayPerlinFactor\":2.0,\"bridgeChance\":0.7,\"ruinMinlevelPercent\":0.8,\"buildingDoorwayChance\":0.6,\"multi_max_x\":2,\"icon\":\"textures/gui/icon_safe.png\",\"parkElevation\":true,\"description\":\"Safe mode: no spawners, lighting but no loot\",\"multi_max_z\":2,\"spawnSphere\":\"\",\"forceSpawnInBuilding\":false,\"terrainFixUpperMinOffset\":-1,\"highwayDistanceMask\":7,\"terrainFixUpperMaxOffset\":1,\"generateLoot\":false,\"terrainFixLowerMaxOffset\":-3,\"chestWithoutLootChance\":0.2,\"terrainFixLowerMinOffset\":-4,\"extraDescription\":\"\",\"landscapeType\":\"default\",\"generateLighting\":false,\"libraryChance\":0.1,\"generateSpawners\":false,\"buildingMinFloorsChance\":4,\"buildingWithoutLootChance\":0.2,\"railwayDungeonChance\":0.01,\"generateNether\":false,\"parkChance\":0.2,\"corridorChance\":0.7,\"randomLeafBlockThickness\":2,\"buildingMaxCellars\":3,\"highwayMainPerlinScale\":50.0},\"cityspheres\":{\"citySphereFactor\":1.2,\"citySphereChance\":0.7,\"outsideProfile\":\"\",\"outsideGroundLevel\":-1,\"onlyPredefined\":false,\"citySphereClearBelow\":0,\"citySphereClearBelowUntilAir\":false,\"monorailOffset\":-2,\"outsideSurfaceVariation\":1.0,\"monorailChance\":0.8,\"citySphereClearAbove\":0,\"citySphereClearAboveUntilAir\":false,\"sphereSurfaceVariation\":1.0},\"public\":false}"
McJty commented 3 months ago

I did some changes to how Lost Cities generates worlds which may (or may not) help with this