McJtyMods / LostCities

MIT License
110 stars 65 forks source link

I'm making a Fabric port what do you need from me? #646

Open TheDarkThief opened 2 weeks ago

TheDarkThief commented 2 weeks ago

Hello,

I am working on porting the mod to Fabric in a port, I have already converted much of the imports to use yarn mappings, and I'm currently working on getting registration and configs working. I hope the port will be finished within a month.

Do you need anything from me (besides credits obviously)?

P.S. Thank you for making this amazing mod and providing me and my friends with hours of good memories :D

McJty commented 2 weeks ago

Credits is fine and if possible a percentage of the CF reward points?

TheDarkThief commented 2 weeks ago

Sure, how does 50/50 sound?

McJty commented 2 weeks ago

That would be good. Thanks. Let me know how things go with this port

TheDarkThief commented 2 weeks ago

Just wanted to give a small update letting you know that I should have configs converted by tomorrow hopefully 🙏 After that the two big things will be registries and hooks to forge

k1r1enko commented 2 weeks ago

Hello,

I am working on porting the mod to Fabric in a port, I have already converted much of the imports to use yarn mappings, and I'm currently working on getting registration and configs working. I hope the port will be finished within a month.

Do you need anything from me (besides credits obviously)?

P.S. Thank you for making this amazing mod and providing me and my friends with hours of good memories :D

Hello! What do u think, how much time do you need to porting? Do you need any help with that?

I also was going to make a port to Fabric.

TheDarkThief commented 2 weeks ago

Hello, I am working on porting the mod to Fabric in a port, I have already converted much of the imports to use yarn mappings, and I'm currently working on getting registration and configs working. I hope the port will be finished within a month. Do you need anything from me (besides credits obviously)? P.S. Thank you for making this amazing mod and providing me and my friends with hours of good memories :D

Hello! What do u think, how much time do you need to porting? Do you need any help with that?

I also was going to make a port to Fabric.

Hello, As I said in the initial post, I'm guessing around a month at my current rate, this is because right now I'm in the easy but tedious phase of just whenever possible replacing something with the Fabric alternative, or just converting to Yarn mappings. That is almost done.

Do I need help? No. Would I like help, YES!

Now it's getting to the phase of converting things that don't have 1:1 equivalents like configuration, which once I'm done from work today I will push the new configuration system using YACL

These are the things that are mostly untouched and I'm not currently working on a solution to port them if you would like to help:

I'm currently working on:

Just fork 1.21-fabric-portingwork and make a PR and any help is much appreciated 😄

My goals with this port are:

These are the things