McJtyMods / RFTools

A set of blocks and items to help with RF in general. Currently contains a Dimension Builder, Teleportation System, Shield System, RF monitor, an RF network debug tool and an automatic crafter
MIT License
226 stars 89 forks source link

Storage Scanner/Tablet causes fps to drop while the interface is openned #1709

Open droped opened 6 years ago

droped commented 6 years ago

Minecraft: 1.12.2
Forge: 14.23.2.2689
McJtyLib: 1.12-2.6.7-SNAPSHOT (2.6.7)
Rftools: 1.12-7.33

When I open the interface of a Storage Scanner or Storage Tablet my fps drops from 60 to 30-25 and stays at 30-25 while it is openned.
The issue is further increased when viewing large inventories like a Refined Storage system or a tablet with a tier 3 storage module. Waiting does not make the fps go up or stabilise.

This does not seem to happen with other guis from the mod.

ghost commented 6 years ago

I am having the same issue. Same RFTools and McJtyLib versions as you. It's currently happening in Enigmatica 2: Expert v1.22. I wonder if it's some weird mod conflict, since it works fine in other modpacks.

McJty commented 6 years ago

That's normal. It has to scan all those inventories so essentially you get the overhead of asking the inventories from all connected blocks

droped commented 6 years ago

But should it drop the fps even with a mere tier 3 storage module (with only 54 items in it)?

McJty commented 6 years ago

Can you show me exactly how that is setup? What blocks and how the scanner is configured etc

droped commented 6 years ago

Sorry for responding so late but I wasn't being able to upload any pictures.

The setup is as so(the rs controller is next to the storage scanner):
2018-05-08_21 39 12

2018-05-08_21 39 45

This is the gui in the storage scanner:
2018-05-08_21 39 30

2018-05-08_21 41 54
You can see that the fps is very low (14 fps) in this picture.

This is my tier 3 storage tablet. I added more items since the last time I commented.
2018-05-08_22 41 12

2018-05-08_22 42 53
You can see that the fps with the storage tablet's gui openned is also low.

This is the storage tablet with the remote upgrade: 2018-05-08_21 40 16

2018-05-08_22 43 27
Notice that the fps is also very low.

And this is the usual fps I get (vsync is set to on outside of minecraft):
2018-05-08_22 42 01

McJty commented 6 years ago

Hmm, this might have something to do with the interface though. I have not seen any slowdown using regular inventories

droped commented 6 years ago

Testing with just RS and Rftools (with no companion mods) doesn't seem to cause any slowdown but it might be that the system simply doesn't have as much stress.