McJtyMods / RFTools

A set of blocks and items to help with RF in general. Currently contains a Dimension Builder, Teleportation System, Shield System, RF monitor, an RF network debug tool and an automatic crafter
MIT License
227 stars 88 forks source link

Crash while interacting with various RFTools machines #1813

Open CritFlaw opened 6 years ago

CritFlaw commented 6 years ago

Issue description: Not consistently, and not always on the same action, but when placing certain machines, or opening their GUI, client experiences a hard crash..

Steps to reproduce: I can't offer reproduction steps because the issue is not present constantly. Sometimes it's after placing a builder (try 100% and 0% infused). A lot of times it's when opening the crafter GUI (try tier 1, 2, 3) that's been the most consistent one, but it isn't every time, only sometimes.

Versions:

Possibly incompatible mods and versions: I use optifine, but I am posting crash logs from two other users who don't use optifine.

Relevant logs, if any:

User PhantomSyndrome, no optifine - https://hastebin.com/wehujunifi.coffeescript User UncleQball, no optifine - https://hastebin.com/rumipofuxo.sql Me, with optifine

josephcsible commented 6 years ago

https://hastebin.com/icepasedoh.coffeescript is a different crash than the rest (a duplicate of McJtyMods/McJtyLib#84 actually).

As for the other 3 crashes, can you all try this build of McJtyLib and post the crash log it gives? mcjtylib-1.12-3.0.2+f2de7c9.zip If the crash doesn't seem to happen with it, check your log files for any regular errors that weren't there before.

Grygon commented 6 years ago

I just got this crash too, here's my log

Going to try the new mcjtylib and see if it helps.

josephcsible commented 6 years ago

That crash is completely different from this one. Please open a new issue for it, and also see if you can reproduce it without Mouse Tweaks.

Grygon commented 6 years ago

Whoops, so it is, I saw a similar enough thing and figured it was the same issue. The new lib did seem to fix it though, so I'm thinking they're probably related.

CritFlaw commented 6 years ago

Using the mcjtylib-1.12-3.0.2+f2de7c9 jar server-side only, using optifine, all version info is the same as the first post in this thread.

https://hastebin.com/jobazoteli.sql

josephcsible commented 6 years ago

Unfortunately, using the jar on the server doesn't make the client's crash log useful.

CritFlaw commented 6 years ago

My server dev just told me that. Thought I'd post it just in case. Any chance you can release this jar on curseforge marked as alpha? Would love to update my pack even with the understanding that it's an unstable release.

josephcsible commented 6 years ago

A regular release will be done tomorrow and will contain this jar's change.

CritFlaw commented 6 years ago

It didn't crash, and it only happened the first time I clicked on a crafter, but when opening a crafter, I saw my items and nothing else, like a fully transparent GUI.

josephcsible commented 6 years ago

Later tonight, I'll make another jar that will help get to the bottom of this.

josephcsible commented 6 years ago

Can you try this build? It should definitely give you a useful crash report. https://github.com/josephcsible/McJtyLib/releases/download/1.12-3.0.2%2Bblamingnonnulllist/mcjtylib-1.12-3.0.2+blamingnonnulllist.jar

If it doesn't, then this one? https://github.com/josephcsible/McJtyLib/releases/download/1.12-3.0.2%2Bblame2/mcjtylib-1.12-3.0.2+blame2.jar

wormzjl commented 6 years ago

Got a similar crash opening the coal gen gui https://gist.github.com/wormzjl/27e05284da8343dece09ed596e022491

josephcsible commented 6 years ago

Can you reproduce it with either of the test builds in my last post?

CritFlaw commented 6 years ago

Which build do you prefer? This is an active server, I can't switch out jars that often.

josephcsible commented 6 years ago

The last one ("blame2")

CritFlaw commented 6 years ago

Forge 2732 McJty 3.0.3 With optifine

Everything else is the same.

https://hastebin.com/sudihaforu.sql

josephcsible commented 6 years ago

We think this is caused by NEI. Try uninstalling it and seeing if that fixes the problem.

CritFlaw commented 6 years ago

Ok, so I haven't done extensive testing without NEI, but it does seem that reducing that mod has resulted in no more crash. That being said, is this a bug I should report to to NEI? Because it's a really useful client-side mod for filtering items when searching, and it also includes light overlays.

josephcsible commented 6 years ago

Yes, report it to them. Also, it looks like everything that NEI does can be done by some combination of other mods: https://docs.google.com/spreadsheets/d/1NEWZjKvWB-SibY1BXc1zoYkK7AhjMMBZess9wMy--6w/htmlview#gid=0

CritFlaw commented 6 years ago

Oh my god someone actually made a spreadsheet for ths? :')

CritFlaw commented 6 years ago

Unfortunately one of the core features I'm looking for, double clicking the search bar to black out all items except the ones you're searching for, doesn't seem to be replaceable.

MauveCloud commented 6 years ago

Unfortunately one of the core features I'm looking for, double clicking the search bar to black out all items except the ones you're searching for, doesn't seem to be replaceable.

If you're searching in chests the mod "Quark" has its own search box (independent of JEI/NEI afaik) that does that, though I'll admit it is more limited (seems to only search by names, not mods or ore dictionary)