search

McJtyMods / RFTools

A set of blocks and items to help with RF in general. Currently contains a Dimension Builder, Teleportation System, Shield System, RF monitor, an RF network debug tool and an automatic crafter
MIT License
226 stars 87 forks source link

Crafter ignoring Thaumcraft Vis Crystal NBT #1857

Open Rodg88 opened 5 years ago

Rodg88 commented 5 years ago

Issue description: Using a RFTools Crafter to try to craft salis mundus from Thaumcraft, which uses 3 different types of vis crystal, doesn't work when you place more than 1 set of materials in the crafter. It seems like it's ignoring the aspects tag on the crystals in the recipe and just trying to use the first three crystals it can, which being stacked, are all the same type, so can't be used to craft the salis mundus.

Steps to reproduce: 2018-10-15_23 24 40 In that screenshot, it's not crafting anything, but if I set it up like this: 2018-10-15_23 25 14 It crafts fine: 2018-10-15_23 25 17

Versions:

McJty commented 5 years ago

I'm afraid it is very hard to solve this. There is no general way for me to recognize that those are really meant to be different ingredients. I recommend avoiding handling those with the same crafter

mhelvens commented 4 years ago

I'm playing Enigmatica 2 (RFTools 1.12-7.72), and I'm running into a similar problem using the Storage Control Screen Module. I tried to set up a screen to manage my inventory of the different crystal types. They show up with different names and colors on the screen, but they all show the same collective counter, and retrieving a stack of any of them indiscriminately gives me the first 64 crystals available.

2020-01-20_17 15 25

I haven't done any mod development myself, so take this with a grain of salt, but it feels like a solvable problem. For example, some mods provide an NBT matching option for their item filters (like XNet), similar to the "Ore Dict matching" option already in this module.

Alternatively, you could consider explicit support for Vis Crystals, since they seem to be implemented in an atypical way, but I understand that's an unattractive option.