McJtyMods / RFTools

A set of blocks and items to help with RF in general. Currently contains a Dimension Builder, Teleportation System, Shield System, RF monitor, an RF network debug tool and an automatic crafter
MIT License
226 stars 88 forks source link

(maybe) [bug] shape card (quarry) dont quarries where it should do #1946

Open ValonInc opened 5 years ago

ValonInc commented 5 years ago

Issue description: Ive set up an builder block with an shaped card (clearing fortune quarry) via Shift+Right klick on builder and right klick on first + second block, iIve set it up far away from my base. the dimensions and offset of it are Dimension: 830, 99, 638 Offset: -309, -22, -3773

but now Ive joined the server and my base nearly got quarried away because it has quarried near my base. am I doing / understanding something wrong with the builder or is it a bug.

Here some images (if it helps): https://imgur.com/a/KsTUj38

Steps to reproduce: I havent had the time to try to reproduce it

Versions:

Im sorry if this is not a bug but just my stupidity :/

Schnetzi8 commented 3 years ago

I have the same issue, I also observed that the bug happend around the zeropoint of a coordinate

McJty commented 3 years ago

No claiming plugins around? FTB Utilities perhaps? If so you have to tell the plugin/mod that handles claimed chunks to allow the builder (fake player) too

Schnetzi8 commented 3 years ago

Previously the builder had quarried in both claimed and unclaimed chunks, so I don`t think that was the issue. We did some further testing and saw that the builder has a range. And when we looked at the config for the Builder we saw the maxBuilderOffset value. This pretty much clears the issue for us.

btw: Minecraft 1.12.2 (Feed the Beast Relevation 3.2.0) RF Tools: 7.72 McJtyLib: 3.5.4

ValonInc commented 3 years ago

So Ive tested a bit with a modpack with only rftools and I think @Schnetzi8 is right.

Ive set up an builder and teleported me 260 blocks away (default "maxBuilderOffset" is 260) to set the shape card corners. Ive run the builder an it only queried the thinks it should. Then Ive set up another builder but twice as far away (520). I let it run and it queried near the first one.

so after all it was somewhat of my fault. even though I think you should have added some sort of warning or something. with maximum dimension of 512 but a maximum range of 260 (by default) it means that it will basically query around the builder and through your house if you set it up in your house.

Testet with

Here some more Images: https://imgur.com/a/Vvjlq1m