search

McJtyMods / RFTools

A set of blocks and items to help with RF in general. Currently contains a Dimension Builder, Teleportation System, Shield System, RF monitor, an RF network debug tool and an automatic crafter
MIT License
226 stars 87 forks source link

Problems when using a custom KubeJS crafting recipe in an RFTools crafter #2164

Open itsjusttriz opened 2 years ago

itsjusttriz commented 2 years ago

Issue description: Beta testing a modpack named Project Isothermal: Expert, and we have a couple custom items and their recipes made with KubeJS. While playing, I tried to place 2 of these custom recipes on the Tier 1 Crafter. 1 of these recipes work, whereas the other doesnt. I assumed the 2nd wasnt working due to the 1st using 1 of the same ingredients, so i removed the 1st recipe from the Crafters memory. Still no result.

Working Recipe is a dirt block made by a shapeless 2x2 of Mud or something. Mud is an item made in KubeJS. Problematic Recipe is a shapeless 2x2 requiring x2 of the before mentioned, Mud, and x2 of another custom item (cant remember the name of) in the shape of:

XO
OX

Steps to reproduce: Create temporary custom items that are mentioned above, and create their recipes using KubeJS. Attempt crafts in a Tier 1 crafter.

Versions:

Possibly incompatible mods and versions: Using Optifine.

Relevant logs, if any:

McJty commented 2 years ago

Are these custom recipes that KubeJS adds standard recipes? i.e. can you make them in a regular crafting table?

itsjusttriz commented 2 years ago

Are these custom recipes that KubeJS adds standard recipes? i.e. can you make them in a regular crafting table?

Yes they are. Basically the first 2 crafts required for this modpack

McJty commented 2 years ago

Hmm not sure then. I have no clue what KubeJS does. The crafter simply looks at the standard recipes returned by the recipe manager. I think you'll have to ask the KubeJS guys if they have a clue what could be wrong.

itsjusttriz commented 2 years ago

Aight thank you.

itsjusttriz commented 2 years ago

@McJty Turns out i was mistaken. The recipe ingredients were custom items made by KubeJS, but the recipe itself was put together with CraftTweaker. The dev of the pack im playing also had the same issue with his previous modpack. Recipe made by CT and attempted automation in the Crafter, with no result. Maybe something to look into?

Kikiisyourfriend commented 2 years ago

Aye. So the items in question are custom items made through KubeJS but the craft itself is from CT. In my other pack Damage Inc I had a custom CT craft for Minecraft Sticks with Minecraft Planks yielding 2 sticks instead of 4 and they were not being auto crafted in the Crafter. Now what's strange is not all CT crafts act this way. I have some going right now that are created with CT and they are working fine. A bit strange. For example my Flesh Block craft using CT in Project Isothermal Expert modpack crafts fine in the Crafter.

McJty commented 2 years ago

Not much I can do about this I'm afraid. As I said the rftools crafter simply uses the standard recipe manager. I have no clue what I could do differently

Kikiisyourfriend commented 2 years ago

I appreciate your time. 😺

jaredlll08 commented 2 years ago

The CraftTweaker Shapeless recipe is a normal ICraftingRecipe that works fine in all other crafters (AE2 / RefinedStorage / Mekanism), so not sure what we could be doing wrong.

https://github.com/CraftTweaker/CraftTweaker/blob/e8cd826790b94e1eeff34b1ccab22778b603c8ca/src/main/java/com/blamejared/crafttweaker/impl/recipes/CTRecipeShapeless.java#L28