McJtyMods / RFToolsBuilder

The RFTools Builder, Shield, Projector, Scanner, ...
MIT License
7 stars 12 forks source link

[1.18.2] Quarry mining into the FTB chunks #120

Closed Sayaniku closed 10 months ago

Sayaniku commented 10 months ago

So, i see when i wake up this morning on another discord some person is griefing with your builder to the claimed FTB Chunks and they break all of the structures and replace everything with lava on public server, and ruin the gameplay of some person, personnaly i just disabled the craft of the builder for skipping that but that really anoying https://media.discordapp.net/attachments/1180211580017836144/1187053739798966333/image.png

McJty commented 10 months ago

That means FTB chunk isn't configured correctly. Fake players should not be allowed to interact with claimed chunks. Not something that I can fix

Sayaniku commented 10 months ago

Yeah but we needed to use the fake player for another mod, and they has nothing on the config to change that

McJty commented 10 months ago

Well that's bad luck. There is really nothing I can do. The Builder is a fake player. I have no other way to interact with ftb claims

McJty commented 10 months ago

Note that the builder uses another fake player. So can't you filter on specific fake players with ftb claims?

Sayaniku commented 10 months ago

i'll check that

Sayaniku commented 10 months ago

yeah i can filter that

Sayaniku commented 10 months ago

i see how now, thx for that and had a great day

Sayaniku commented 10 months ago

nvm, that doesn't work, everything is on false https://cdn.discordapp.com/attachments/1180817668010410055/1187356185330974731/2023-12-21_12-27-04.mp4 The record is bad because i had an bad computer sorry for that

McJty commented 10 months ago

Best get help with the FTB Claims people. That's on their side. I never use that mod

Sayaniku commented 10 months ago

okay i'll check that with the devs of FTB chunks Thx and had a great day

desht commented 10 months ago

Hi McJty - I'm the current FTB Chunks maintainer. Just wanted to check: the Builder fake player is named "rftools_builder", right? And what UUID does it use?

The issue here is that a simple fake player which has the same name for all players on the server is impossible to protect against by mods like FTB Chunks, since it can't distinguish the fake player from Player A's Builder from evil griefing Player B's Builder. Meaning griefers can set up a Builder and remotely trash someone's base, even if they to protect with FTB Chunks or similar.

The only real solution is to give each Builder's fake player the same name and UUID of the owner, i.e. the player who placed down the Builder (for reference, Mekanism's Digital Miner does this, as do PNC:R Drones and both mods interact nicely with FTB Chunks protected chunks). Not sure if you have that functionality present in the Builder, though?

McJty commented 10 months ago

The name is indeed "rftools_builder" and the UUID is taken from the owner of the builder. So the player owner.

desht commented 10 months ago

Ok, thanks. Guess I need to get in and see if I can reproduce the issue then :)

desht commented 10 months ago

Just to note, I did some testing and the Builder interacts correctly with FTB Chunks, refusing to mine any chunks which are protected by the chunk owner (but mining as expected when protection is removed). So I suspect a problem with setup on the OP's server. I'll stop bothering you now :smile:

Sayaniku commented 10 months ago

i just maked without bypass protection and without op with one of my player on a claimed chunk with the default config on ftb chunk, the quarry can mine in every case