McJtyMods / RFToolsControl

RFTools Control is an addon for RFTools adding a programmable logic block
MIT License
34 stars 18 forks source link

Rftools control unable to autocraft botania flowers #75

Open zashra00 opened 7 years ago

zashra00 commented 7 years ago

Current version is whatever is in ftb beyond. Looks like the processor is unable to differentiate between botanias flowers so it wont craft the flower you want and instead crafts whatever card is in the first slot of the crafting card inventory. Quick note. Pretty sure it's not on botanias end since I can work around it by renaming different items and using that as the output

McJty commented 7 years ago

Botania flowers are all the same item but with different metadata so maybe you can take that into account? Unsure though as you didn't give a lot of information on exactly what you're doing

zashra00 commented 7 years ago

I put all the components into a crafting card and put the corresponding flower in the output slot. My program which is almost exactly identical to the string i use for runes gets ingredients smart from my storage scanner and moves them to a automatic precision dropper above a petal apothecary. The problem unfortunately happens before all of this when it goes into the inventory to get the recipie from the crafting card instead of using the correct card it uses whatever card is in the inventories first slot and before you ask I've tried vanilla chests aa storage crates and even the almighty modular storage unit all with the same result

zashra00 commented 7 years ago

any suggestions or am I stuck renaming a new item for each flower?

McJty commented 7 years ago

Can you copy/paste the program here? (ctrl-c in the programmer)

zashra00 commented 7 years ago

sure

zashra00 commented 7 years ago

[ { "pos": { "x": 6, "y": 7 }, "opcode": { "id": "do_delay", "primary": "D", "parameters": [ { "type": "integer", "value": { "v": 20 } } ] } }, { "pos": { "x": 5, "y": 7 }, "opcode": { "id": "do_rs", "primary": "R", "parameters": [ { "type": "side", "value": { "side": "east", "node": "rc" } }, { "type": "integer", "value": { "v": 0 } } ] } }, { "pos": { "x": 6, "y": 8 }, "opcode": { "id": "do_fetchitems", "primary": "D", "parameters": [ { "type": "inventory", "value": { "side": "east", "node": "rc" } }, { "type": "integer", "value": { "null": true } }, { "type": "item", "value": { "null": true } }, { "type": "integer", "value": { "null": true } }, { "type": "integer", "value": { "v": 0 } }, { "type": "boolean", "value": { "null": true } }, { "type": "boolean", "value": { "null": true } } ] } }, { "pos": { "x": 7, "y": 9 }, "opcode": { "id": "do_craftok", "parameters": [ { "type": "integer", "value": { "null": true } } ] } }, { "pos": { "x": 4, "y": 7 }, "opcode": { "id": "do_releaselock", "primary": "L", "parameters": [ { "type": "string", "value": { "v": "rune" } } ] } }, { "pos": { "x": 5, "y": 8 }, "opcode": { "id": "do_delay", "primary": "U", "parameters": [ { "type": "integer", "value": { "v": 80 } } ] } }, { "pos": { "x": 6, "y": 9 }, "opcode": { "id": "do_releaselock", "primary": "R", "parameters": [ { "type": "string", "value": { "v": "rune" } } ] } }, { "pos": { "x": 3, "y": 7 }, "opcode": { "id": "do_delay", "primary": "L", "parameters": [ { "type": "integer", "value": { "v": 60 } } ] } }, { "pos": { "x": 4, "y": 8 }, "opcode": { "id": "test_eq", "primary": "D", "secondary": "u", "parameters": [ { "type": "integer", "value": { "fun": "last_int" } }, { "type": "integer", "value": { "v": 0 } } ] } }, { "pos": { "x": 5, "y": 9 }, "opcode": { "id": "do_pushmulti", "primary": "U", "parameters": [ { "type": "inventory", "value": { "side": "down", "node": "drop2" } }, { "type": "integer", "value": { "v": 10 } }, { "type": "integer", "value": { "v": 23 } }, { "type": "integer", "value": { "v": 1 } } ] } }, { "pos": { "x": 2, "y": 7 }, "opcode": { "id": "do_lock", "primary": "D", "parameters": [ { "type": "string", "value": { "v": "rune" } } ] } }, { "pos": { "x": 3, "y": 8 }, "opcode": { "id": "test_eq", "primary": "D", "secondary": "r", "parameters": [ { "type": "integer", "value": { "fun": "last_int" } }, { "type": "integer", "value": { "v": -1 } } ] } }, { "pos": { "x": 4, "y": 9 }, "opcode": { "id": "do_rs", "primary": "R", "parameters": [ { "type": "side", "value": { "side": "east", "node": "rc" } }, { "type": "integer", "value": { "v": 15 } } ] } }, { "pos": { "x": 2, "y": 8 }, "opcode": { "id": "do_getingredients_smart", "primary": "R", "parameters": [ { "type": "inventory", "value": { "null": true } }, { "type": "inventory", "value": { "side": "east" } }, { "type": "item", "value": { "null": true } }, { "type": "integer", "value": { "v": 10 } }, { "type": "integer", "value": { "v": 23 } }, { "type": "inventory", "value": { "side": "down" } } ] } }, { "pos": { "x": 3, "y": 9 }, "opcode": { "id": "do_releaselock", "primary": "L", "parameters": [ { "type": "string", "value": { "v": "rune" } } ] } }, { "pos": { "x": 1, "y": 8 }, "opcode": { "id": "do_lock", "primary": "R", "parameters": [ { "type": "string", "value": { "v": "rune" } } ] } }, { "pos": { "x": 2, "y": 9 }, "opcode": { "id": "do_craftfail", "primary": "R", "parameters": [] } }, { "pos": { "x": 0, "y": 8 }, "opcode": { "id": "ev_craft", "primary": "R", "parameters": [ { "type": "item", "value": { "null": true } }, { "type": "inventory", "value": { "side": "east" } }, { "type": "boolean", "value": { "null": true } } ] } } ]

zashra00 commented 7 years ago

a bit longer than I expected XD

zashra00 commented 7 years ago

Any news?

Shephiroth commented 7 years ago

I just made a PR fixing this.

Some time ago i made a fix, thinking that the only metadata problem was detecting the item the user click in the station.....

This time the problem was choosing the right crafting card.

This will fix crafting with metada, but not sure where else it could be needed.

zashra00 commented 7 years ago

Probably partly botanias fault since if you pull up the advanced tooltips they are all specialflower

Shephiroth commented 7 years ago

I think i made this clear....is not botania's fault.....its "not handling" metadata in RFToolsControl. I hope the PR to be accepted soon.

MagmaiKH commented 6 years ago

I'm having a similar problem with IC2's insulated and uninsulated cables, The crafting cards have the right type in them but the smart-fetch appears to be ignoring the metadata (it never triggers a craft event to create insulated cable) and it uses uninsulated cable for recipes calling for insulated.