McJtyMods / RFToolsDimensions

Companion mod for RFTools which handles the dimensions
MIT License
63 stars 24 forks source link

[1.10.2] RTG terrain in RFTools dimensions #105

Open whichonespink44 opened 7 years ago

whichonespink44 commented 7 years ago

Hi McJty -

We're in the process of adding the ability to generate RTG's realistic terrain in dimensions other than the Overworld, and I was wondering if you could share your thoughts on what would need to happen in order for RTG to be able to generate its realistic terrain in RFTools dimensions.

For example, would we need to provide you with a RTGTerrainGenerator.java class to sit alongside the other terrain generators in /src/main/java/mcjty/rftoolsdim/dimensions/world/terrain/ ? Or is that something you would do? Would it even be necessary?

Similarly, would we need a RTGChunkGenerator.java class to sit alongside the others in /src/main/java/mcjty/rftoolsdim/dimensions/world/ ?

I suspect we might need both since RTG doesn't just handle the terrain generation, but also the surfacing (top bock, filler block, etc) and the biome decorations, but... I'm not familiar enough with the RFTools codebase yet to know for sure, so I thought I'd throw it out there to open the doors of communication.

Thanks for your time, Pink

McJty commented 7 years ago

Actually I'm not sure either. I haven't messed with terrain generation before except manual generation like what I'm doing in rftools dimensions. Having an RTGTerrainGenerator would probably be the easiest solution for me but then it would obviously only have an effect in that specific terrain type.

I must admit I don't know a lot about biome decorations but I'm surprised that RTG handles that. What if a modded biome has special biome decorations. How does that work with RTG?

whichonespink44 commented 7 years ago

What if a modded biome has special biome decorations. How does that work with RTG?

RTG can decorate biomes itself with custom decorations (which is how it decorates most of the vanilla biomes), but it can also delegate decoration to the biome itself (which is how it decorates most modded biomes). It's actually capable of doing both, so sometimes it lets the mod biome decorate itself, and then RTG will come in and place a few custom trees here and there.

Having an RTGTerrainGenerator would probably be the easiest solution for me but then it would obviously only have an effect in that specific terrain type.

Doing an RTGTerrainGenerator would probably be doable, but @Zeno410 would need to get involved as the terrain side of things is a little outside my skillset, and I might be completely wrong. Having it only affect RFTools dimensions that use the 'RTG' terrain type would be fine (that's sort of how I imagined it anyway).

It's the RTGChunkGenerator that worries me the most as I'm struggling to see how we could extract RTG's chunk generation system for use in RFTD. It's a very complicated system, made even more complicated by the fact that it's built on legacy code from RWG, which wasn't written with this sort of mod compatibility in mind.)

McJty commented 7 years ago

Will get back to you on this later. Bit busy now

McJty commented 7 years ago

I seem to have neglected this a bit. Sorry for that. Is this still an issue for you?