GridTE performance

[Sir-Will]

Any chance this can be improved?

[McJty]

How many grids do you have on the multiblock?

[Sir-Will]

No idea, hard to tell with 30 players.

[Sir-Will]

Just noticed that I posted this in the wrong repo, sorry about that. Want me to move it to EFab?

[McJty]

It's ok. Most likely the issue is multiple grids on the same efab multiblock and that issue is already fixed and ready for next release

[Sir-Will]

Is that commit already on github? I would like to put the fix already on the server side.

[McJty]

That's too complicated. EFab depends on a heavily modified McjtyLib so you would have to compile all my mods from github. Also all the clients would have to be updated as well

[Sir-Will]

The clients don't need to be updated as the grid calculation is only done by the server, except you do something out of the ordinary. This also shouldn't be complicated if the fix is not a complete rewrite of multiple classes.

[McJty]

No but a lot of other things have changed in the mod too. You could try to get an older version and try to do the same fix on that. It is not a complicated fix

[Sir-Will]

That's why I'm was asking about the commit to see what was changed to fix this issue. It's at 9% now so I really would like to get this issue fixed asap and also test if it actually fixes this issue.

[Sir-Will]

Is it this fix you were talking about? https://github.com/McJtyMods/EFab/commit/e32edde29bc067688a5b572d6cb1a5dc42c26044

[McJty]

yes indeed. Note that yesterday I released alpha versions of all my mods. But maybe that's too risky and complicated to distribute to all your uses. In any case, the commit above is the fix you want

[Sir-Will]

Hm, that removed code doesn't use func_180495_p (getBlockState) which is the main issue.

[McJty]

It does. Indirectly. I'm pretty sure that will be the reason. The removed code makes sure that there is no cascade of updates which all use getBlockState