McJtyMods / TheOneProbe

This simple mod adds a probe and an API for other mods to show information with that probe
MIT License
137 stars 67 forks source link

server crashes when i add in top but works fine in singleplayer #629

Open geterhun opened 10 months ago

geterhun commented 10 months ago

hi my server crashes pretty much everytime i try to start my server idk why as it never has before i am using my moodpack called mysticcrafthttps://legacy.curseforge.com/minecraft/modpacks/mysticmodpackunleashed/files [crash-2023-12-01_17.43.56-fml.txt] (https://github.com/McJtyMods/TheOneProbe/files/13575573/crash-2023-12-01_17.43.56-fml.txt)

McJty commented 10 months ago

That's weird. This works fine for other people. TOP is used a lot. So I suspect there is some mod conflict but I can't imagine what mod would cause this

cylian914 commented 9 months ago

i got the same error, it seem that gtceu is the issue

btw i made a litle py script to get common mods, very usefull when there is an incopatiblity.

screret commented 9 months ago

@McJty Could we get an official way to add tool types from a plugin? sorry if that already exists and we just couldn't find it btw.

this seems to be a regression from the 1.12 version where this wasn't so hardcoded...

McJty commented 9 months ago

Tool types from a plugin? What do you mean by that?

screret commented 9 months ago

like if my mod adds custom tools TOP won't show those in the popup because they're not in the config

McJty commented 9 months ago

There is not really a way for me to solve that. I don't have a way to get those extra tool types as far as I know

screret commented 9 months ago

could add a hook for plugins to supply custom ones maybe?

screret commented 9 months ago

also, changing the String in that map to a Component would help greatly

McJty commented 9 months ago

You are talking about plugins. I suppose you mean mods right? Because plugins and mods are not the same thing

screret commented 9 months ago

yes, sorry; I meant TOP plugins. whatever those are called now

McJty commented 9 months ago

Just mods

screret commented 9 months ago

whatever the terminology, my current solution is this gross hack & I'd like a more acessible API in TOP for adding these.

screret commented 9 months ago

because as it turns out, that particular gross hack breaks sometimes.

cylian914 commented 9 months ago

it break because of "import net.minecraft.client.resources.language.I18n;", and its (obviously) not existant in a server