search

McJtyMods / XNet

Advanced item/liquid/energy/... networking
MIT License
96 stars 53 forks source link

Is there a limit to how many connections in a channel that can be pasted at once? #408

Open CendolPulut opened 4 years ago

CendolPulut commented 4 years ago

Issue description: I've noticed that i can't paste a channel that has more than 40 connections. When i do so, it'll give an error saying "Clipboard too large". I wanted to know if there's an actual limit and if there is a way to remove or change it.

Steps to reproduce: Open the controller, establish a channel and make more than 40 connections, click "Copy". Go to another channel and click "Paste"

Versions:

Possibly incompatible mods and versions:

Relevant logs, if any:

McJty commented 4 years ago

That's not a limit on my side. I guess it's a limit of the OS clipboard or something?

CendolPulut commented 4 years ago

That's not a limit on my side. I guess it's a limit of the OS clipboard or something?

Limit of the OS clipboard? The error came up in the style of a message "Copied channel" so it's definitely something from the mod itself. I wonder if it is actually the OS.

McJty commented 4 years ago

Well I show the message but the actual error is something that I get from the clipboard manager which is handled by the OS

CendolPulut commented 4 years ago

Well I show the message but the actual error is something that I get from the clipboard manager which is handled by the OS

Ah i see. Is there a way to remove or change the limit?

McJty commented 4 years ago

No idea actually...

CendolPulut commented 4 years ago

Well that's a bummer. I guess i'll just have to paste as many as i can and do the rest by hand. It's gonna be a pain but since it's not something you implemented then there's no other way i guess. Thanks anyway!

malton33 commented 4 years ago

I'm also having this issue. It's definitely a limit in the mod, at the very least it should be configurable.

McJty commented 4 years ago

Actually you are right. It is a limit that I build in. I forgot about that. The problem is that increasing the limit is a bit hard. The clipboard contents is generated server side since it has all the information and network packets from client to server are limited to 32K. So fixing this will require a bit more work (and I'll only fix this on 1.15.2 as well as I no longer work on 1.12)

malton33 commented 4 years ago

Thanks for clarification. Glad to hear that this has been acknowledged