search

McJtyMods / XNet

Advanced item/liquid/energy/... networking
MIT License
94 stars 53 forks source link

Xnet Kicks Whenever editing something in controller #471

Open Aminboss2 opened 3 years ago

Aminboss2 commented 3 years ago

Issue description: whenever you try to change anything in the controller it kicks you from the server and says Payload my not be lager than 32767 bytes I am running my own server not on my pc but on a paid service

Steps to reproduce: I have no idea but it works fine in singleplayer but not on the server

Versions:

Possibly incompatible mods and versions: Here is My Mod List its a Custom ModPack Made By Me https://imgur.com/a/20YBQ1v

Relevant logs, if any: There are no logs since I don't crash but just get kicked from the server here is a video of it happing https://youtu.be/zhnAexLY5UY

McJty commented 3 years ago

Hmm, do you happen to have a huge number of connected blocks perhaps?

Aminboss2 commented 3 years ago

I don't the only thing connected is the connector on the controller it could be the Storage Drawers I have about 20 of them connected to my Mining Quarry With a Qwark item pipe I also tried moving 200 blocks away from my base still didn't do much

Here is a Video Of Me Showing My Base Maybe there is something I don't see that you can https://youtu.be/K25PG63cR1g also sorry about the video you can see the pixels when I run. I had my OBS setting messed up And I am not the only one that Gets Kicked if my friends do it they will get kicked with the game error as well

Edit: here is a Better Video With Fixed Settings https://youtu.be/G2k4La5KMvk Also, I have tried the latest of xNet Still comes up with the same error so I went down to see if the issue is fixed but still not

McJty commented 3 years ago

I need to get the logs on server and client when this kick happens

McJty commented 3 years ago

@Aminboss2 bump?

Dunkmania101 commented 3 years ago

It happens to me too. Here's all the log says about it:

[25Feb2021 18:49:52.356] [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: Dunkmania101 lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Payload may not be larger than 32767 bytes

It looks like a giant packet is being sent, my guess is from the client-side of the GUI. I opened the controller, created a channel, and went to edit a connection. It didn't kick me until I put a 1 in the "maximum items in the other inventory" box.

McJty commented 3 years ago

hmm. Ok. I'll try to find anything

McJty commented 3 years ago

Whenever I do this in my dev env I get a packet of about 2000. So that should be fine. I wonder if there is some mod messing with this. Do you have YNot perhaps?

Dunkmania101 commented 3 years ago

I'm in 1.16.5, but I do have XNetGasses, which I'm pretty sure does the same thing. I'll test removing it.

McJty commented 3 years ago

Thanks! If you can investigate this problem to see if it depends on other mods then that would be perfect

Dunkmania101 commented 3 years ago

It seems to work just fine without Xnet Gasses. I removed the mod and was able to edit the connections on my server without problems. I'll report it to them, thanks!

McJty commented 3 years ago

ok thanks! I wonder what they do to cause this though

Terrails commented 3 years ago

I have just tried doing the exact same steps I was given at my repo https://github.com/Terrails/XNetGases/issues/7, but I can't seem to reproduce this. Looking through this thread I can see that the OP doesn't have XNetGases installed, which I confirmed with their video. I just can't see why XNetGases would cause this.

Dunkmania101 commented 3 years ago

I did look through XNetGasses's code and didn't see anything related to packets, or even really GUIs for that matter. It's weird that removing it was what fixed it for me.

Dazohan commented 3 years ago

Im getting the same issue on a server that isnt running XnetGasses. Same error and everything. Every time i try to create or modify a liquid or logic channel so far.

Aminboss2 commented 3 years ago

It happens to me too. Here's all the log says about it:

[25Feb2021 18:49:52.356] [Server thread/INFO] [net.minecraft.network.play.ServerPlayNetHandler/]: Dunkmania101 lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.io.IOException: Payload may not be larger than 32767 bytes

It looks like a giant packet is being sent, my guess is from the client-side of the GUI. I opened the controller, created a channel, and went to edit a connection. It didn't kick me until I put a 1 in the "maximum items in the other inventory" box.

Hey Yeah Sorry I was gone for a little while but yeah I get the same msg on my server not idea why

edit: YNot is for 1.12.2 I am in 1.16.4 also if you think a mod is doing this I do have a mod list check original post also I can send you a mod download if you would like but it works perfectly fine in single-player but not in multi-player also for me its items not liquids or logic

Edit: Here is Full Server Log https://pastebin.com/kmia5x7e

Also If you would like to test it with my mods here are the files for the mods https://www.dropbox.com/s/fwyer0jhz492x3r/mods.rar?dl=0

Virustotal Scan For the Files If you wanted to check https://www.virustotal.com/gui/file/e078457bff8bf3f80b9cad12e96baf9eca349f5dd8ff2f42478d96fe146a45e9/detection

Also its Forge 35.1.37 Mc 1.16.4 Make Sure You Do it in MultiPlayer