Network Cables break if they are placed in water blocks, or touched by running water.

McJtyMods / XNet

Advanced item/liquid/energy/... networking

MIT License

92 stars 51 forks source link

Network Cables break if they are placed in water blocks, or touched by running water. #476

Closed b-bilko closed 3 years ago

b-bilko commented 3 years ago

Issue description: Cables break if they are placed in water blocks, or touched by running water.

Steps to reproduce:

Running as part of Direwolf 20 1.16 pack

Place a network cable in water, it instantly breaks.

Placing a water block near a connected network breaks the cables.

Versions:

Minecraft: 1.16
Forge: 36.0.45
CompatLayer (only if on Minecraft 1.10 or 1.11):
McJtyLib: mcjtylib-1.16-5.0.17
XNet: xnet-1.16-3.0.11

Possibly incompatible mods and versions:

OptiFine_1.16.4_HD_U_G6

Relevant logs, if any:

TheRealWormbo commented 3 years ago

Can confirm:

Minecraft 1.16.5
Forge 36.1.0
McJtyLib: 1.16-5.0.19
XNet: 1.16-3.0.11
(no Optifine)

The behavior is somewhat unexpected and quite different from similar blocks in other mods, where cable/pipe/connector-like blocks can actually be waterlogged instead of being flushed away by water. The benefits of waterlogging would be both functional (e.g. automating underwater-contraptions with XNet) and decorative (e.g. having visible cables in water).

McJty commented 3 years ago

I will fix this

McJty commented 3 years ago

Ok, fixing the breaking in water is easy. For some reason I made the cables use material.CARPET. I changed it to IRON (same material that the connectors use). I'm now looking into waterlogging

McJty commented 3 years ago

Fixed and implemented waterlogging. Version has been released